Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30960
Change subject: superio/it8716f: fix pnp_dev_info ......................................................................
superio/it8716f: fix pnp_dev_info
Change-Id: If6a4b6f52425a795af34264ab839968b36a117eb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/ite/it8716f/superio.c 1 file changed, 12 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/30960/1
diff --git a/src/superio/ite/it8716f/superio.c b/src/superio/ite/it8716f/superio.c index 50ab2b9..8017fd8 100644 --- a/src/superio/ite/it8716f/superio.c +++ b/src/superio/ite/it8716f/superio.c @@ -75,17 +75,19 @@ };
static struct pnp_info pnp_dev_info[] = { - { NULL, IT8716F_FDC, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x07f8, }, - { NULL, IT8716F_SP1, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { NULL, IT8716F_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { NULL, IT8716F_PP, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x07f8, }, - { NULL, IT8716F_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x07f8, 0x07f8, }, - { NULL, IT8716F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x07ff, 0x07ff, }, + { NULL, IT8716F_FDC, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x0ff8, }, + { NULL, IT8716F_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, + { NULL, IT8716F_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, + { NULL, IT8716F_PP, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_DRQ0, + 0x0ff8, 0x0ffc, }, + { NULL, IT8716F_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x0ff8, 0x0ff8, }, + { NULL, IT8716F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x0fff, 0x0fff, }, { NULL, IT8716F_KBCM, PNP_IRQ0, }, - { NULL, IT8716F_GPIO, PNP_IO1 | PNP_IO2, 0, 0x07f8, 0x07f8, }, - { NULL, IT8716F_MIDI, PNP_IO0 | PNP_IRQ0, 0x07fe, }, - { NULL, IT8716F_GAME, PNP_IO0, 0x07ff, }, - { NULL, IT8716F_IR, }, + { NULL, IT8716F_GPIO, PNP_IO0 | PNP_IO1 | PNP_IO2, + 0x0ff8, 0x0ff8, 0x0ff8, }, + { NULL, IT8716F_MIDI, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, + { NULL, IT8716F_GAME, PNP_IO0, 0x07f8, }, + { NULL, IT8716F_IR, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, };
static void enable_dev(struct device *dev)
Felix Held has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/30960 )
Change subject: superio/it8716f: fix pnp_dev_info ......................................................................
superio/it8716f: fix pnp_dev_info
Change-Id: If6a4b6f52425a795af34264ab839968b36a117eb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/ite/it8716f/superio.c 1 file changed, 12 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/30960/2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30960 )
Change subject: superio/it8716f: fix pnp_dev_info ......................................................................
Patch Set 3: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30960 )
Change subject: superio/it8716f: fix pnp_dev_info ......................................................................
superio/it8716f: fix pnp_dev_info
Change-Id: If6a4b6f52425a795af34264ab839968b36a117eb Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/30960 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M src/superio/ite/it8716f/superio.c 1 file changed, 12 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/src/superio/ite/it8716f/superio.c b/src/superio/ite/it8716f/superio.c index 50ab2b9..a986d7a 100644 --- a/src/superio/ite/it8716f/superio.c +++ b/src/superio/ite/it8716f/superio.c @@ -75,17 +75,19 @@ };
static struct pnp_info pnp_dev_info[] = { - { NULL, IT8716F_FDC, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x07f8, }, - { NULL, IT8716F_SP1, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { NULL, IT8716F_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, - { NULL, IT8716F_PP, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x07f8, }, - { NULL, IT8716F_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x07f8, 0x07f8, }, - { NULL, IT8716F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x07ff, 0x07ff, }, + { NULL, IT8716F_FDC, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x0ff8, }, + { NULL, IT8716F_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, + { NULL, IT8716F_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, + { NULL, IT8716F_PP, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_DRQ0, + 0x0ff8, 0x0ffc, }, + { NULL, IT8716F_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x0ff8, 0x0ff8, }, + { NULL, IT8716F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x0fff, 0x0fff, }, { NULL, IT8716F_KBCM, PNP_IRQ0, }, - { NULL, IT8716F_GPIO, PNP_IO1 | PNP_IO2, 0, 0x07f8, 0x07f8, }, - { NULL, IT8716F_MIDI, PNP_IO0 | PNP_IRQ0, 0x07fe, }, - { NULL, IT8716F_GAME, PNP_IO0, 0x07ff, }, - { NULL, IT8716F_IR, }, + { NULL, IT8716F_GPIO, PNP_IO0 | PNP_IO1 | PNP_IO2, + 0x0ff8, 0x0ff8, 0x0ff8, }, + { NULL, IT8716F_MIDI, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, + { NULL, IT8716F_GAME, PNP_IO0, 0x0ff8, }, + { NULL, IT8716F_IR, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, };
static void enable_dev(struct device *dev)
-
Felix Held (Code Review) -
Stefan Reinauer (Code Review)