Attention is currently required from: Avi Uday, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Pranava Y N.
Subrata Banik has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/87286?usp=email )
Change subject: mb/google/fatcat: Optimize CBFS backed option API
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/fatcat/common.c:
https://review.coreboot.org/c/coreboot/+/87286/comment/a04e8bc3_11524dc0?usp... :
PS7, Line 11:
Can you move this file into the baseboard directory ? (which is ideally a common code for all variants)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87286?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I37b33bc8fa14b3760d6d78102e0cf256310d9ac3
Gerrit-Change-Number: 87286
Gerrit-PatchSet: 7
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Avi Uday
aviuday@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Avi Uday
aviuday@google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 21 Apr 2025 05:54:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No