Attention is currently required from: Paul Menzel, Alex Levin.
Ravindra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51795 )
Change subject: soc/intel/alderlake: Enable HWP CPPC support in CB
......................................................................
Patch Set 8:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51795/comment/bd077158_7fb32b42
PS1, Line 7: HGS
coreboot don't expected to publish anything for HGS+ and what you have done is HWP ACPI table.
corrected the commit message
Commit Message:
https://review.coreboot.org/c/coreboot/+/51795/comment/721fe39a_25718bc1
PS2, Line 7: [adl-p pre-CEP] HGS+ and ITBM support in CB
Please use a statement. […]
Ack
Patchset:
PS7:
Also mark all comments as Resolved
all comments resolved. Marked branch as public.
Patchset:
PS8:
all comments resolved and commit message updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d93774e8025466f1911cf77459910fe872bfcc8
Gerrit-Change-Number: 51795
Gerrit-PatchSet: 8
Gerrit-Owner: Ravindra
ravindra@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Nathan D Ciobanu
nathan.d.ciobanu@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravindra
ravindra@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alex Levin
levinale@google.com
Gerrit-Comment-Date: Fri, 30 Apr 2021 10:26:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment