Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59913 )
Change subject: cpu/x86/Makefile.inc: Build smi_trigger on !HAVE_SMI_HANDLER ......................................................................
cpu/x86/Makefile.inc: Build smi_trigger on !HAVE_SMI_HANDLER
A lot of soc code requires a definition of apm_control, which smm/smi_trigger.c provided for !HAVE_SMI_HANDLER, but is not added as a build target.
Fixes building Q35 without smihandler.
Change-Id: Ie57819b3d169311371a1caca83c9b0c796b46048 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/x86/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/59913/1
diff --git a/src/cpu/x86/Makefile.inc b/src/cpu/x86/Makefile.inc index b9f6417..bff8a01 100644 --- a/src/cpu/x86/Makefile.inc +++ b/src/cpu/x86/Makefile.inc @@ -2,6 +2,8 @@ subdirs-y += mtrr subdirs-y += pae subdirs-$(CONFIG_HAVE_SMI_HANDLER) += smm +# this has valid definitions on !HAVE_SMI_HANDLER +ramstage-y += smm/smi_trigger.c subdirs-$(CONFIG_UDELAY_TSC) += tsc
all-$(CONFIG_ARCH_ALL_STAGES_X86_64) += 64bit/mode_switch.S