HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39077 )
Change subject: mb/biostar/a68n_5200: Remove unused 'usb_oc.asl' ......................................................................
mb/biostar/a68n_5200: Remove unused 'usb_oc.asl'
Also remove old reference in comment to Olivehill.
Change-Id: Id4711cd1b7fdf49207d5e7c3abd4e077a921ee98 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- D src/mainboard/biostar/a68n_5200/acpi/usb_oc.asl M src/mainboard/biostar/a68n_5200/dsdt.asl 2 files changed, 0 insertions(+), 132 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/39077/1
diff --git a/src/mainboard/biostar/a68n_5200/acpi/usb_oc.asl b/src/mainboard/biostar/a68n_5200/acpi/usb_oc.asl deleted file mode 100644 index 513d66d..0000000 --- a/src/mainboard/biostar/a68n_5200/acpi/usb_oc.asl +++ /dev/null @@ -1,129 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2012 Advanced Micro Devices, Inc. - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* simple name description */ -/* -#include <arch/acpi.h> -DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 - ) - { - #include "usb.asl" - } -*/ - -/* USB overcurrent mapping pins. */ -Name(UOM0, 0) -Name(UOM1, 2) -Name(UOM2, 0) -Name(UOM3, 7) -Name(UOM4, 2) -Name(UOM5, 2) -Name(UOM6, 6) -Name(UOM7, 2) -Name(UOM8, 6) -Name(UOM9, 6) - -/* USB Overcurrent GPEs */ - -#if 0 /* TODO: Update for Olivehill */ -Method(UCOC, 0) { - Sleep(20) - Store(0x13,CMTI) - Store(0,GPSL) -} - -/* USB Port 0 overcurrent uses Gpm 0 */ -If(LLessEqual(UOM0,9)) { - Scope (_GPE) { - Method (_L13) { - } - } -} - -/* USB Port 1 overcurrent uses Gpm 1 */ -If (LLessEqual(UOM1,9)) { - Scope (_GPE) { - Method (_L14) { - } - } -} - -/* USB Port 2 overcurrent uses Gpm 2 */ -If (LLessEqual(UOM2,9)) { - Scope (_GPE) { - Method (_L15) { - } - } -} - -/* USB Port 3 overcurrent uses Gpm 3 */ -If (LLessEqual(UOM3,9)) { - Scope (_GPE) { - Method (_L16) { - } - } -} - -/* USB Port 4 overcurrent uses Gpm 4 */ -If (LLessEqual(UOM4,9)) { - Scope (_GPE) { - Method (_L19) { - } - } -} - -/* USB Port 5 overcurrent uses Gpm 5 */ -If (LLessEqual(UOM5,9)) { - Scope (_GPE) { - Method (_L1A) { - } - } -} - -/* USB Port 6 overcurrent uses Gpm 6 */ -If (LLessEqual(UOM6,9)) { - Scope (_GPE) { - /* Method (_L1C) { */ - Method (_L06) { - } - } -} - -/* USB Port 7 overcurrent uses Gpm 7 */ -If (LLessEqual(UOM7,9)) { - Scope (_GPE) { - /* Method (_L1D) { */ - Method (_L07) { - } - } -} - -/* USB Port 8 overcurrent uses Gpm 8 */ -If (LLessEqual(UOM8,9)) { - Scope (_GPE) { - Method (_L17) { - } - } -} - -/* USB Port 9 overcurrent uses Gpm 9 */ -If (LLessEqual(UOM9,9)) { - Scope (_GPE) { - Method (_L0E) { - } - } -} -#endif diff --git a/src/mainboard/biostar/a68n_5200/dsdt.asl b/src/mainboard/biostar/a68n_5200/dsdt.asl index c4fc934..06a2dee 100644 --- a/src/mainboard/biostar/a68n_5200/dsdt.asl +++ b/src/mainboard/biostar/a68n_5200/dsdt.asl @@ -30,9 +30,6 @@ /* Globals for the platform */ #include "acpi/mainboard.asl"
- /* Describe the USB Overcurrent pins */ - #include "acpi/usb_oc.asl" - /* PCI IRQ mapping for the Southbridge */ #include <southbridge/amd/agesa/hudson/acpi/pcie.asl>
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39077 )
Change subject: mb/biostar/a68n_5200: Remove unused 'usb_oc.asl' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39077/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39077/1//COMMIT_MSG@7 PS1, Line 7: unused well, you remove the user. What's unused about it?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39077 )
Change subject: mb/biostar/a68n_5200: Remove unused 'usb_oc.asl' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39077/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39077/1//COMMIT_MSG@7 PS1, Line 7: unused
well, you remove the user. […]
you mean "Remove dead code" is more appropriate?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39077 )
Change subject: mb/biostar/a68n_5200: Remove unused 'usb_oc.asl' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39077/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39077/1//COMMIT_MSG@7 PS1, Line 7: unused
you mean "Remove dead code" is more appropriate?
The issue is that I don't understand why it's dead (except that you remove it and the include pointing to the file)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39077
to look at the new patch set (#2).
Change subject: mb/biostar/a68n_5200/acpi: Remove commented out code ......................................................................
mb/biostar/a68n_5200/acpi: Remove commented out code
Change-Id: Id4711cd1b7fdf49207d5e7c3abd4e077a921ee98 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/a68n_5200/acpi/usb_oc.asl 1 file changed, 0 insertions(+), 90 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/39077/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39077
to look at the new patch set (#3).
Change subject: mb/biostar/a68n_5200/acpi: Remove commented out code ......................................................................
mb/biostar/a68n_5200/acpi: Remove commented out code
Change-Id: Id4711cd1b7fdf49207d5e7c3abd4e077a921ee98 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/biostar/a68n_5200/acpi/usb_oc.asl 1 file changed, 0 insertions(+), 92 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/39077/3
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39077 )
Change subject: mb/biostar/a68n_5200/acpi: Remove commented out code ......................................................................
Abandoned
maybe one can update it for Olivehill
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)