Bill XIE has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/78288?usp=email )
Change subject: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume ......................................................................
drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume
After commit e12b313844da ("drivers/pc80/rtc/option.c: Allow CMOS defaults to extend to bank 1"), Thinkpad X200 with CONFIG(STATIC_OPTION_TABLE) can no longer resume from s3 (detected via bisect), but resetting CMOS seems unnecessary during s3 resume.
Now, cmos_need_reset will be negated by acpi_is_wakeup_s3() returning true.
Tested: Thinkpad X200 with CONFIG(STATIC_OPTION_TABLE) can resume from s3 again with these changes.
Change-Id: I533e83f3b95f327b0e24f4d750f8812325b7770b Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M src/drivers/pc80/rtc/option.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/78288/2