Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
AUTHORS: add authors from src/superio
TODO: I'm not sure if QingPei Wang and Wang Qing Pei are the same person and if that's the case which name should be put in the AUTHORS file.
Change-Id: I6d56380beef7023c60d6fbb47c520ec6f6a7c9db Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M AUTHORS 1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/38543/1
diff --git a/AUTHORS b/AUTHORS index 6fbee9d..59e3c9d 100644 --- a/AUTHORS +++ b/AUTHORS @@ -10,6 +10,7 @@
9elements Agency GmbH Advanced Micro Devices, Inc. +AG Electronics Ltd. Alex Züpke Alexander Couzens Alexandru Gagniuc @@ -20,20 +21,27 @@ ASPEED Technology Inc. Atheros Corporation Atmel Corporation +BAP - Bruhnspace Advanced Projects Carl-Daniel Hailfinger +Christoph Grenz coresystems GmbH +Corey Osgood Damien Zammit David Brownell David Hendricks David Mosberger-Tang Denis Dowling DENX Software Engineering +Digital Design Corporation DMP Electronics Inc. Drew Eckhardt +Dynon Avionics +Edward O'Callaghan Egbert Eich Eltan B.V Eric Biederman Eswar Nallusamy +Fabian Kunkel Facebook, Inc. Felix Held Frederic Potter @@ -41,6 +49,7 @@ Freescale Semiconductor, Inc. Gary Jennejohn Gerd Hoffmann +Gergely Kiss Google LLC Greg Watson Idwer Vollering @@ -53,11 +62,13 @@ Joseph Smith Keith Hui Keith Packard +Kevin Cody-Little Kshitij Kyösti Mälkki Lei Wen Li-Ta Lo Libra Li +Libretrend LDA Linus Torvalds Linux Networx, Inc. Luc Verhaegen @@ -67,34 +78,45 @@ Martin Mares Marvell International Ltd. Marvell Semiconductor Inc. +Matt DeVillier MediaTek Inc. +Mondrian Nuessle MontaVista Software, Inc. Myles Watson Network Appliance Inc. Nicholas Sielicki Nick Barker Nico Huber +Nicola Corna Ollie Lo +Omar Pakker Orion Technologies, LLC Patrick Georgi Patrick Rudolph +Pavel Sayekat PC Engines GmbH Per Odlund Peter Stuge +Philipp Degler +Protectli +QingPei Wang Raptor Engineering, LLC Red Hat Inc Reinhard Meyer +Richard Spiegel Richard Woodruff Ronald G. Minnich Rudolf Marek Russell King Sage Electronic Engineering, LLC Samsung Electronics +Samuel Holland SciTech Software, Inc. Sebastian Grzywna secunet Security Networks AG Siemens AG Silicon Integrated System Corporation +Silverback ltd. Stefan Reinauer Steve Magnani ST Microelectronics @@ -102,16 +124,22 @@ Sven Schnelle Syed Mohammed Khasim Texas Instruments +The ChromiumOS Authors The Linux Foundation Thomas Winischhofer Timothy Pearson +Tobias Diedrich Tungsten Graphics, Inc. Tyan Computer Corp. ucRobotics Inc. +University of Heidelberg Uwe Hermann VIA Technologies, Inc Vipin Kumar +Vladimir Serbinenko +Wang Qing Pei Ward Vandewege +Win Enterprises Wolfgang Denk Yinghai Lu
@@ -125,3 +153,4 @@ src/cpu src/device src/drivers +src/superio
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 1: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 1:
i added the names from the copyright lines from src/superio there; should i also have looked at the git history there?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 1:
Patch Set 1:
i added the names from the copyright lines from src/superio there; should i also have looked at the git history there?
That would make me appear on the list :D
On a more serious note: IANAL. However, you might be able to figure out if QingPei and Wang Qing Pei are the same person.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 1:
Since I'm not 100% sure on things here, I added Martin and Patrick; not sure who else I should add here
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38543/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38543/1//COMMIT_MSG@9 PS1, Line 9: TODO: I'm not sure if QingPei Wang and Wang Qing Pei are the same person Same person. If you want to keep last names at the end, use QingPei Wang. If you want to go for "how they call themselves at home (in a formal setting)" that would be Wang QingPei. (rule of thumb, as described in more detail in [0]: Chinese names tend to have two syllables in the given name, one syllable in the family name. Therefore Xi Jinping, current head of state is Mr. Xi)
For companies, use their latest name only (they typically inherit rights from their former selves), but feel free to add somebody of that company to the review in case it's a special case.
(and in most general terms, the Berne convention rights are automatic, so even if you leave out a name by mistake that's not a huge drama but something we can simply fix)
[0] https://ufal.mff.cuni.cz/pdt2.0/doc/manuals/en/m-layer/html/ch03s01s02.html
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 1:
Patch Set 1:
i added the names from the copyright lines from src/superio there; should i also have looked at the git history there?
No, people are free to add themselves to AUTHORS if they feel they're eligible (and we can fact check it then). Other than that, I'd expect the various copyright lines across the entire source tree, packed into the single AUTHORS file to be a relatively accurate collection of copyright holders.
(as in: a developer might not have added themselves to src/superio copyrights even though they might be eligible to, but they probably did in the mainboard or chipset code or whatever so by and large it sorts itself out)
Hello Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38543
to look at the new patch set (#2).
Change subject: AUTHORS: add authors from src/superio ......................................................................
AUTHORS: add authors from src/superio
Change-Id: I6d56380beef7023c60d6fbb47c520ec6f6a7c9db Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M AUTHORS 1 file changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/38543/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38543/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38543/1//COMMIT_MSG@9 PS1, Line 9: TODO: I'm not sure if QingPei Wang and Wang Qing Pei are the same person
Same person. If you want to keep last names at the end, use QingPei Wang. […]
ok, i used the version with the family name first.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 2: Code-Review+1
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38543 )
Change subject: AUTHORS: add authors from src/superio ......................................................................
AUTHORS: add authors from src/superio
Change-Id: I6d56380beef7023c60d6fbb47c520ec6f6a7c9db Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/38543 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M AUTHORS 1 file changed, 28 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/AUTHORS b/AUTHORS index 6fbee9d..d41c958 100644 --- a/AUTHORS +++ b/AUTHORS @@ -10,6 +10,7 @@
9elements Agency GmbH Advanced Micro Devices, Inc. +AG Electronics Ltd. Alex Züpke Alexander Couzens Alexandru Gagniuc @@ -20,20 +21,27 @@ ASPEED Technology Inc. Atheros Corporation Atmel Corporation +BAP - Bruhnspace Advanced Projects Carl-Daniel Hailfinger +Christoph Grenz coresystems GmbH +Corey Osgood Damien Zammit David Brownell David Hendricks David Mosberger-Tang Denis Dowling DENX Software Engineering +Digital Design Corporation DMP Electronics Inc. Drew Eckhardt +Dynon Avionics +Edward O'Callaghan Egbert Eich Eltan B.V Eric Biederman Eswar Nallusamy +Fabian Kunkel Facebook, Inc. Felix Held Frederic Potter @@ -41,6 +49,7 @@ Freescale Semiconductor, Inc. Gary Jennejohn Gerd Hoffmann +Gergely Kiss Google LLC Greg Watson Idwer Vollering @@ -53,11 +62,13 @@ Joseph Smith Keith Hui Keith Packard +Kevin Cody-Little Kshitij Kyösti Mälkki Lei Wen Li-Ta Lo Libra Li +Libretrend LDA Linus Torvalds Linux Networx, Inc. Luc Verhaegen @@ -67,34 +78,44 @@ Martin Mares Marvell International Ltd. Marvell Semiconductor Inc. +Matt DeVillier MediaTek Inc. +Mondrian Nuessle MontaVista Software, Inc. Myles Watson Network Appliance Inc. Nicholas Sielicki Nick Barker Nico Huber +Nicola Corna Ollie Lo +Omar Pakker Orion Technologies, LLC Patrick Georgi Patrick Rudolph +Pavel Sayekat PC Engines GmbH Per Odlund Peter Stuge +Philipp Degler +Protectli Raptor Engineering, LLC Red Hat Inc Reinhard Meyer +Richard Spiegel Richard Woodruff Ronald G. Minnich Rudolf Marek Russell King Sage Electronic Engineering, LLC Samsung Electronics +Samuel Holland SciTech Software, Inc. Sebastian Grzywna secunet Security Networks AG Siemens AG Silicon Integrated System Corporation +Silverback ltd. Stefan Reinauer Steve Magnani ST Microelectronics @@ -102,16 +123,22 @@ Sven Schnelle Syed Mohammed Khasim Texas Instruments +The ChromiumOS Authors The Linux Foundation Thomas Winischhofer Timothy Pearson +Tobias Diedrich Tungsten Graphics, Inc. Tyan Computer Corp. ucRobotics Inc. +University of Heidelberg Uwe Hermann VIA Technologies, Inc Vipin Kumar +Vladimir Serbinenko +Wang Qing Pei Ward Vandewege +Win Enterprises Wolfgang Denk Yinghai Lu
@@ -125,3 +152,4 @@ src/cpu src/device src/drivers +src/superio
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Frans Hendriks (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)