Attention is currently required from: Tim Wawrzynczak, Zhi7 Li, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette:Add fw_config probe for codec ALC5682I-VD & VS compatibility
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56930/comment/e10b229f_ab26e4c5
PS9, Line 7: mb/google/dedede/var/sasukette:Add
Please add a space after the colon.
https://review.coreboot.org/c/coreboot/+/56930/comment/17474ea5_9b404714
PS9, Line 8: codec ALC5682I-VD & VS compatibility
Please put it on one line.
https://review.coreboot.org/c/coreboot/+/56930/comment/c55e61c9_8a768eba
PS9, Line 10: Change the `_HID` value depending on the the fw_config values
Please elaborate, and maybe note, where you copied this from.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 9
Gerrit-Owner: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 16 Aug 2021 12:47:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment