Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19723 )
Change subject: soc/amd/stoneyridge: Add CPU files ......................................................................
Patch Set 2:
(1 comment)
Other files could probably benefit from the same include file cleanup, but this one's pointing at the wrong BiosCallOuts.h.
Also, it would be nice to shorten that, i.e. remove the pathname, but mainboard directory is getting -I included first and it also contains a BiosCallOuts.h.
https://review.coreboot.org/#/c/19723/2/src/soc/amd/common/heapmanager.c File src/soc/amd/common/heapmanager.c:
PS2, Line 15: #include "AGESA.h" : #include "amdlib.h" : #include <northbridge/amd/pi/BiosCallOuts.h> : #include "heapManager.h" #include <AGESA.h> #include <amdlib.h> #include <soc/amd/common/BiosCallOuts.h> #include <heapManager.h>
Also, we've talked about my preference for putting AMD stuff after other includes (the ones below).