Attention is currently required from: Julius Werner, Yu-Ping Wu.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59834 )
Change subject: lib: Fix edge case of log2_ceil()
......................................................................
Patch Set 1:
(1 comment)
File tests/lib/lib-test.c:
https://review.coreboot.org/c/coreboot/+/59834/comment/3a47fe9c_c3423019
PS1, Line 46: log2_ceil(0xffffffff)
In the original implementation this will be 31: […]
Nice catch. It really should have been 32, but until now it behaved like ordinary log2() without the ceil()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59834
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If868f793b909a6ad7fc48a7affac15e2c714fa2e
Gerrit-Change-Number: 59834
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 08:23:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment