Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36591 )
Change subject: console: serial: add optional delay to wait for BMC serial routing ......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4:
I'm not really convinced that adding quirk handling in generic common code like this is such a good idea. What is wrong with the current code which adds a delay in the bootblock in the mainboard code?
Because not only one board has that problem
The mainboard bootblock code is always supposed to setup the superio at the moment so handling the quirks there is the best place to do that. It's ok to have some duplication of that. Exposing the amounts of seconds in Kconfig is not really nice, but that's a personal opinion. I don't like Kconfig options to be something you have to tune and experiment with to get it right. It should present just options that are meaningful for different use cases.