Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33269
Change subject: nb/amd/amdmct/mct_ddr3: Remove unused code ......................................................................
nb/amd/amdmct/mct_ddr3: Remove unused code
As described in the comment, the BKDG-recommended algorithm causes problems and isn't being used, so just delete it.
Change-Id: Ib3d4eba7ea2d7f6545613af5670b243bc011275f Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1347325, 1347326 --- M src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c 1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/33269/1
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c index ab16887..42f313a 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c @@ -1213,13 +1213,6 @@ Seed_Fine = (SeedTotal[ByteLane] % 32) + 32; }
- if (Seed_Gross == 0) - Seed_PreGross = 0; - else if (Seed_Gross & 0x1) - Seed_PreGross = 1; - else - Seed_PreGross = 2; - /* The BKDG-recommended algorithm causes problems with registered DIMMs on some systems * due to the long register delays causing premature total delay wrap-around. * Attempt to work around this...
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33269 )
Change subject: nb/amd/amdmct/mct_ddr3: Remove unused code ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33269 )
Change subject: nb/amd/amdmct/mct_ddr3: Remove unused code ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33269 )
Change subject: nb/amd/amdmct/mct_ddr3: Remove unused code ......................................................................
nb/amd/amdmct/mct_ddr3: Remove unused code
As described in the comment, the BKDG-recommended algorithm causes problems and isn't being used, so just delete it.
Change-Id: Ib3d4eba7ea2d7f6545613af5670b243bc011275f Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1347325, 1347326 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33269 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c 1 file changed, 0 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c index ab16887..42f313a 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c @@ -1213,13 +1213,6 @@ Seed_Fine = (SeedTotal[ByteLane] % 32) + 32; }
- if (Seed_Gross == 0) - Seed_PreGross = 0; - else if (Seed_Gross & 0x1) - Seed_PreGross = 1; - else - Seed_PreGross = 2; - /* The BKDG-recommended algorithm causes problems with registered DIMMs on some systems * due to the long register delays causing premature total delay wrap-around. * Attempt to work around this...
-
Angel Pons (Code Review) -
Jacob Garber (Code Review)
-
Patrick Georgi (Code Review)