Attention is currently required from: Felix Singer, Marc Jones, Jeff Daly, Subrata Banik, Paul Menzel, Angel Pons, Michael Niewöhner.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60829 )
Change subject: util/ifdtool: Add additional regions for platforms that support them
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
Patchset:
PS12:
This looks fine to me, but I'd like someone who actually knows something about the intel platforms to review it.
Are all of these fields public?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5a450e5002e9f8edee76ca7c2eede9906df36c5
Gerrit-Change-Number: 60829
Gerrit-PatchSet: 12
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 03 Feb 2022 17:41:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment