Nicolò has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37992 )
Change subject: mb/google/slippy: Fix IRQ of the ambient light sensor ......................................................................
mb/google/slippy: Fix IRQ of the ambient light sensor
Change-Id: Ib2a8356d261d211d5ed5c0b035c94ec56b9c25b3 Signed-off-by: Nicolò Veronese nicveronese@gmail.com --- M src/mainboard/google/slippy/onboard.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/37992/1
diff --git a/src/mainboard/google/slippy/onboard.h b/src/mainboard/google/slippy/onboard.h index 9e1dc8b..7c40e23 100644 --- a/src/mainboard/google/slippy/onboard.h +++ b/src/mainboard/google/slippy/onboard.h @@ -17,7 +17,7 @@ #define ONBOARD_H
#define BOARD_LIGHTSENSOR_NAME "lightsensor" -#define BOARD_LIGHTSENSOR_IRQ 51 /* PIRQT */ +#define BOARD_LIGHTSENSOR_IRQ 35 /* PIRQT */ #define BOARD_LIGHTSENSOR_I2C_BUS 2 /* I2C1 */ #define BOARD_LIGHTSENSOR_I2C_ADDR 0x44
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37992 )
Change subject: mb/google/slippy: Fix IRQ of the ambient light sensor ......................................................................
Patch Set 1: Code-Review+2
I'd add a note in the commit message as to how the correct IRQ was derived, and that the ACPI code using this will be added in a follow-up commit
Hello Angel Pons, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37992
to look at the new patch set (#2).
Change subject: mb/google/slippy: Fix IRQ of the ambient light sensor Change based on google/auron that is similar to peppy. ......................................................................
mb/google/slippy: Fix IRQ of the ambient light sensor Change based on google/auron that is similar to peppy.
This will be helpful for the next follow-up commit that will add ACPI for the ambient light sensor.
Change-Id: Ib2a8356d261d211d5ed5c0b035c94ec56b9c25b3 Signed-off-by: Nicolò Veronese nicveronese@gmail.com --- M src/mainboard/google/slippy/onboard.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/37992/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37992 )
Change subject: mb/google/slippy: Fix IRQ of the ambient light sensor Change based on google/auron that is similar to peppy. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37992/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37992/2//COMMIT_MSG@8 PS2, Line 8: Change based on google/auron that is similar to peppy. add an empty line to separate the summary from the body. As is, the line is considered a continuation of the summary
Patrick Georgi has uploaded a new patch set (#3) to the change originally created by Nicolò. ( https://review.coreboot.org/c/coreboot/+/37992 )
Change subject: mb/google/slippy: Fix IRQ of the ambient light sensor ......................................................................
mb/google/slippy: Fix IRQ of the ambient light sensor
Change based on google/auron that is similar to peppy.
This will be helpful for the next follow-up commit that will add ACPI for the ambient light sensor.
Change-Id: Ib2a8356d261d211d5ed5c0b035c94ec56b9c25b3 Signed-off-by: Nicolò Veronese nicveronese@gmail.com --- M src/mainboard/google/slippy/onboard.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/37992/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37992 )
Change subject: mb/google/slippy: Fix IRQ of the ambient light sensor ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37992/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37992/2//COMMIT_MSG@8 PS2, Line 8: Change based on google/auron that is similar to peppy.
add an empty line to separate the summary from the body. […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37992 )
Change subject: mb/google/slippy: Fix IRQ of the ambient light sensor ......................................................................
mb/google/slippy: Fix IRQ of the ambient light sensor
Change based on google/auron that is similar to peppy.
This will be helpful for the next follow-up commit that will add ACPI for the ambient light sensor.
Change-Id: Ib2a8356d261d211d5ed5c0b035c94ec56b9c25b3 Signed-off-by: Nicolò Veronese nicveronese@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37992 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/slippy/onboard.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/google/slippy/onboard.h b/src/mainboard/google/slippy/onboard.h index 9e1dc8b..7c40e23 100644 --- a/src/mainboard/google/slippy/onboard.h +++ b/src/mainboard/google/slippy/onboard.h @@ -17,7 +17,7 @@ #define ONBOARD_H
#define BOARD_LIGHTSENSOR_NAME "lightsensor" -#define BOARD_LIGHTSENSOR_IRQ 51 /* PIRQT */ +#define BOARD_LIGHTSENSOR_IRQ 35 /* PIRQT */ #define BOARD_LIGHTSENSOR_I2C_BUS 2 /* I2C1 */ #define BOARD_LIGHTSENSOR_I2C_ADDR 0x44
-
Matt DeVillier (Code Review) -
Nicolò (Code Review)
-
Patrick Georgi (Code Review)