Attention is currently required from: char, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72827 )
Change subject: superio/ite: Add support for ITE IT8987e ......................................................................
Patch Set 4:
(4 comments)
File src/superio/ite/it8987e/superio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169934): https://review.coreboot.org/c/coreboot/+/72827/comment/56bbf56e_53d3f1bc PS4, Line 18: if (!dev->enabled) suspect code indent for conditional statements (16, 32)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169934): https://review.coreboot.org/c/coreboot/+/72827/comment/82624ec0_4c2eb48e PS4, Line 70: if (!conf) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169934): https://review.coreboot.org/c/coreboot/+/72827/comment/9d698370_9c574869 PS4, Line 70: if (!conf) suspect code indent for conditional statements (16, 16)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169934): https://review.coreboot.org/c/coreboot/+/72827/comment/5a9c6771_ab8157a7 PS4, Line 73: } else { suspect code indent for conditional statements (8, 24)