You-Cheng Syu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33355
Change subject: mediatek/mt8183: Support RTC in ramstage ......................................................................
mediatek/mt8183: Support RTC in ramstage
We need to support RTC in ramstage so that we can see correct timestamp in ChromiumOS eventlog.
BUG=b:134461866 TEST='mosys eventlog list' shows correct timestamp on Kukui
Change-Id: Idb0fe5c05e4ecdf0e6398e3c781c71d14f85f19b --- M src/soc/mediatek/mt8183/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/33355/1
diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc index 5392a9e..d35a07e 100644 --- a/src/soc/mediatek/mt8183/Makefile.inc +++ b/src/soc/mediatek/mt8183/Makefile.inc @@ -45,6 +45,8 @@ ramstage-y += ../common/gpio.c gpio.c ramstage-y += ../common/mmu_operations.c mmu_operations.c ramstage-y += ../common/mtcmos.c mtcmos.c +ramstage-y += ../common/pmic_wrap.c +ramstage-y += ../common/rtc.c rtc.c ramstage-y += soc.c ramstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c ramstage-y += ../common/timer.c
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33355
to look at the new patch set (#2).
Change subject: mediatek/mt8183: Support RTC in ramstage ......................................................................
mediatek/mt8183: Support RTC in ramstage
We need to support RTC in ramstage so that we can see correct timestamp in ChromiumOS eventlog.
BUG=b:134461866 TEST='mosys eventlog list' shows correct timestamp on Kukui
Change-Id: Idb0fe5c05e4ecdf0e6398e3c781c71d14f85f19b Signed-off-by: You-Cheng Syu youcheng@google.com --- M src/soc/mediatek/mt8183/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/33355/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33355 )
Change subject: mediatek/mt8183: Support RTC in ramstage ......................................................................
Patch Set 2: Code-Review+1
+1 - also defer to Julius.
@jwerner do we prefer to add such rules in soc folder, or simply do that in board folder?
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33355 )
Change subject: mediatek/mt8183: Support RTC in ramstage ......................................................................
Patch Set 2: Code-Review+2
@jwerner do we prefer to add such rules in soc folder, or simply do that in board folder?
Not sure what you mean? This is correct. src/soc/... files should be referenced by the src/soc/.../Makefile (and this one already has these for romstage, this patch is just expanding that to ramstage).
If we had an optional SoC driver that only some boards need, we'd still have the rules in the SoC Makefile and maybe add an option in src/soc/.../Kconfig to guard it which gets selected by the mainboard. But that would only be necessary if you really have a need to exclude the code on some boards... most of the time it's just providing some functions that will simply be garbage collected if the mainboard code doesn't call them.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33355 )
Change subject: mediatek/mt8183: Support RTC in ramstage ......................................................................
Patch Set 2:
ok I see. thanks for the explanation.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33355 )
Change subject: mediatek/mt8183: Support RTC in ramstage ......................................................................
mediatek/mt8183: Support RTC in ramstage
We need to support RTC in ramstage so that we can see correct timestamp in ChromiumOS eventlog.
BUG=b:134461866 TEST='mosys eventlog list' shows correct timestamp on Kukui
Change-Id: Idb0fe5c05e4ecdf0e6398e3c781c71d14f85f19b Signed-off-by: You-Cheng Syu youcheng@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33355 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/soc/mediatek/mt8183/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Hung-Te Lin: Looks good to me, but someone else must approve
diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc index 5392a9e..d35a07e 100644 --- a/src/soc/mediatek/mt8183/Makefile.inc +++ b/src/soc/mediatek/mt8183/Makefile.inc @@ -45,6 +45,8 @@ ramstage-y += ../common/gpio.c gpio.c ramstage-y += ../common/mmu_operations.c mmu_operations.c ramstage-y += ../common/mtcmos.c mtcmos.c +ramstage-y += ../common/pmic_wrap.c +ramstage-y += ../common/rtc.c rtc.c ramstage-y += soc.c ramstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c ramstage-y += ../common/timer.c
-
Hung-Te Lin (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)
-
You-Cheng Syu (Code Review)