Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48101 )
Change subject: docs/mb/supermicro/x11-lga-series: Update documentation
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Thank you for maintaining the documentation.
Next time, maybe two commits (general and board specific) would be nice to have.
https://review.coreboot.org/c/coreboot/+/48101/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48101/4//COMMIT_MSG@10
PS4, Line 10: CB:35726
No idea, why this is not marked up as a link by Gerrit.
https://review.coreboot.org/c/coreboot/+/48101/4//COMMIT_MSG@14
PS4, Line 14: - Drop vanished issue on PCIe warning.
: - Drop TODO section, since the TODOs are done.
Nit: I’d remove the dots/periods at the end.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5becfa9ea01a0d9d651c6b51b30ebfcedb6412a5
Gerrit-Change-Number: 48101
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Nov 2020 09:47:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment