Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57055 )
Change subject: mb/system76/*: cmos.layout: Reserve century byte ......................................................................
mb/system76/*: cmos.layout: Reserve century byte
Windows will write to the century byte (0x32), causing the option table checksum to be invalid and reset all options to their default values. Move options and checksum to start after the century byte.
Change-Id: Ia395acacda1e251251c880587bbf61d7ee81ba3d Signed-off-by: Tim Crawford tcrawford@system76.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/57055 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jeremy Soller jeremy@system76.com --- M src/mainboard/system76/gaze15/cmos.layout M src/mainboard/system76/lemp9/cmos.layout M src/mainboard/system76/oryp5/cmos.layout M src/mainboard/system76/oryp6/cmos.layout M src/mainboard/system76/whl-u/cmos.layout 5 files changed, 25 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Jeremy Soller: Looks good to me, approved
diff --git a/src/mainboard/system76/gaze15/cmos.layout b/src/mainboard/system76/gaze15/cmos.layout index c0275d6..ba36b0b 100644 --- a/src/mainboard/system76/gaze15/cmos.layout +++ b/src/mainboard/system76/gaze15/cmos.layout @@ -8,8 +8,11 @@ 384 1 e 4 boot_option 388 4 h 0 reboot_counter
-395 4 e 6 debug_level +# RTC_CLK_ALTCENTURY +400 8 r 0 century + 409 2 e 7 power_on_after_fail +412 4 h 6 debug_level 984 16 h 0 check_sum
enumerations @@ -33,4 +36,4 @@
checksums
-checksum 392 983 984 +checksum 408 983 984 diff --git a/src/mainboard/system76/lemp9/cmos.layout b/src/mainboard/system76/lemp9/cmos.layout index c0275d6..ca7c7a4 100644 --- a/src/mainboard/system76/lemp9/cmos.layout +++ b/src/mainboard/system76/lemp9/cmos.layout @@ -8,8 +8,11 @@ 384 1 e 4 boot_option 388 4 h 0 reboot_counter
-395 4 e 6 debug_level +# RTC_CLK_ALTCENTURY +400 8 r 0 century + 409 2 e 7 power_on_after_fail +412 4 e 6 debug_level 984 16 h 0 check_sum
enumerations @@ -33,4 +36,4 @@
checksums
-checksum 392 983 984 +checksum 408 983 984 diff --git a/src/mainboard/system76/oryp5/cmos.layout b/src/mainboard/system76/oryp5/cmos.layout index c0275d6..ca7c7a4 100644 --- a/src/mainboard/system76/oryp5/cmos.layout +++ b/src/mainboard/system76/oryp5/cmos.layout @@ -8,8 +8,11 @@ 384 1 e 4 boot_option 388 4 h 0 reboot_counter
-395 4 e 6 debug_level +# RTC_CLK_ALTCENTURY +400 8 r 0 century + 409 2 e 7 power_on_after_fail +412 4 e 6 debug_level 984 16 h 0 check_sum
enumerations @@ -33,4 +36,4 @@
checksums
-checksum 392 983 984 +checksum 408 983 984 diff --git a/src/mainboard/system76/oryp6/cmos.layout b/src/mainboard/system76/oryp6/cmos.layout index c0275d6..ca7c7a4 100644 --- a/src/mainboard/system76/oryp6/cmos.layout +++ b/src/mainboard/system76/oryp6/cmos.layout @@ -8,8 +8,11 @@ 384 1 e 4 boot_option 388 4 h 0 reboot_counter
-395 4 e 6 debug_level +# RTC_CLK_ALTCENTURY +400 8 r 0 century + 409 2 e 7 power_on_after_fail +412 4 e 6 debug_level 984 16 h 0 check_sum
enumerations @@ -33,4 +36,4 @@
checksums
-checksum 392 983 984 +checksum 408 983 984 diff --git a/src/mainboard/system76/whl-u/cmos.layout b/src/mainboard/system76/whl-u/cmos.layout index c0275d6..ca7c7a4 100644 --- a/src/mainboard/system76/whl-u/cmos.layout +++ b/src/mainboard/system76/whl-u/cmos.layout @@ -8,8 +8,11 @@ 384 1 e 4 boot_option 388 4 h 0 reboot_counter
-395 4 e 6 debug_level +# RTC_CLK_ALTCENTURY +400 8 r 0 century + 409 2 e 7 power_on_after_fail +412 4 e 6 debug_level 984 16 h 0 check_sum
enumerations @@ -33,4 +36,4 @@
checksums
-checksum 392 983 984 +checksum 408 983 984
-
Felix Held (Code Review)