HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Makefile.inc: Remove redundant warning flag
'-Wstrict-aliasing' is turned on by '-Wall'
Change-Id: I51eb8241389f13d2659aef0a3b4b376ce9c651cf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/44216/1
diff --git a/Makefile.inc b/Makefile.inc index 2526c25..a54b76c 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -422,7 +422,7 @@ CFLAGS_common += -pipe -g -nostdinc -std=gnu11 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough -CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits -Wvla +CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla CFLAGS_common += -Wlogical-op -Wduplicated-cond -Wdangling-else CFLAGS_common += -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44216
to look at the new patch set (#2).
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Makefile.inc: Remove redundant warning flag
'-Wstrict-aliasing' is turned on by '-Wall'
Change-Id: I51eb8241389f13d2659aef0a3b4b376ce9c651cf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/44216/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44216
to look at the new patch set (#4).
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Makefile.inc: Remove redundant warning flag
'-Wstrict-aliasing' is turned on by '-Wall'. '-Wstrict-aliasing' is only active when -fstrict-aliasing is active, so add it.
Change-Id: I51eb8241389f13d2659aef0a3b4b376ce9c651cf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/44216/4
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Patch Set 4:
(1 comment)
Did you build test it? Do the images change, when building with `BUILD_TIMELESS=1`?
https://review.coreboot.org/c/coreboot/+/44216/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44216/4//COMMIT_MSG@10 PS4, Line 10: is Please remove one space.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44216
to look at the new patch set (#5).
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Makefile.inc: Remove redundant warning flag
'-Wstrict-aliasing' is turned on by '-Wall'. '-Wstrict-aliasing' is only active when -fstrict-aliasing is active, so add it.
'BUILD_TIMELESS=1' on gigabyte/ga-945gcm-s2l gives the same binary.
Change-Id: I51eb8241389f13d2659aef0a3b4b376ce9c651cf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/44216/5
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Patch Set 5:
(1 comment)
Patch Set 4:
(1 comment)
Did you build test it? Do the images change, when building with `BUILD_TIMELESS=1`?
Thank you, yes, tested on GA-945GCM-S2, it gives the same md5sum.
https://review.coreboot.org/c/coreboot/+/44216/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44216/4//COMMIT_MSG@10 PS4, Line 10: is
Please remove one space.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Patch Set 5: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Patch Set 5:
I'd rather keep them because compiler defaults may vary.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Patch Set 5:
Patch Set 5:
I'd rather keep them because compiler defaults may vary.
Sorry, I'm not to understand "compiler defaults"
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 5:
I'd rather keep them because compiler defaults may vary.
Sorry, I'm not to understand "compiler defaults"
Oops, I'm not sure to* understand what you mean by "compiler defaults"
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Patch Set 6:
Patch Set 5:
Patch Set 5:
Patch Set 5:
I'd rather keep them because compiler defaults may vary.
Sorry, I'm not to understand "compiler defaults"
Oops, I'm not sure to* understand what you mean by "compiler defaults"
do you man gcc version ? if so, '-Wstrict-aliasing' is turned on by '-Wall' since gcc-4.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44216 )
Change subject: Makefile.inc: Remove redundant warning flag ......................................................................
Makefile.inc: Remove redundant warning flag
'-Wstrict-aliasing' is turned on by '-Wall'. '-Wstrict-aliasing' is only active when -fstrict-aliasing is active, so add it.
'BUILD_TIMELESS=1' on gigabyte/ga-945gcm-s2l gives the same binary.
Change-Id: I51eb8241389f13d2659aef0a3b4b376ce9c651cf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44216 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/Makefile.inc b/Makefile.inc index a51b73d..9d27743 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -422,10 +422,10 @@ CFLAGS_common += -pipe -g -nostdinc -std=gnu11 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough -CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits -Wvla +CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla CFLAGS_common += -Wlogical-op -Wduplicated-cond -Wdangling-else CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer -CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie +CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie ifeq ($(CONFIG_COMPILER_GCC),y) # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)