build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62097 )
Change subject: nb/amd/amdfam10/bootblock.c: Use HT defined register values ......................................................................
Patch Set 1:
(7 comments)
File src/northbridge/amd/amdfam10/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141274): https://review.coreboot.org/c/coreboot/+/62097/comment/683fcbc9_fe1aa6dd PS1, Line 48: u16 flags = pci_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141274): https://review.coreboot.org/c/coreboot/+/62097/comment/f2885b05_644a40a5 PS1, Line 48: u16 flags = pci_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141274): https://review.coreboot.org/c/coreboot/+/62097/comment/24ac9a84_9721583f PS1, Line 129: count = (flags >> HT_PRIMARY_UNIT_COUNT_OFFSET) & HT_PRIMARY_UNIT_COUNT_MASK; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141274): https://review.coreboot.org/c/coreboot/+/62097/comment/95fb96d6_d5020d8a PS1, Line 146: if (ctrl & (HT_LINK_CTRL_LINK_FAIL | HT_LINK_CTRL_CRC_UNRECOV_ERR)) { line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141274): https://review.coreboot.org/c/coreboot/+/62097/comment/ccd5a35f_00f187ae PS1, Line 154: ctrl |= (HT_LINK_CTRL_LINK_FAIL | HT_LINK_CTRL_CRC_UNRECOV_ERR); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141274): https://review.coreboot.org/c/coreboot/+/62097/comment/bff6fe87_54f0ed3d PS1, Line 157: if (ctrl & (HT_LINK_CTRL_LINK_FAIL | HT_LINK_CTRL_CRC_UNRECOV_ERR)) { line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141274): https://review.coreboot.org/c/coreboot/+/62097/comment/b8430313_3b51dec1 PS1, Line 157: if (ctrl & (HT_LINK_CTRL_LINK_FAIL | HT_LINK_CTRL_CRC_UNRECOV_ERR)) { Too many leading tabs - consider code refactoring
-
build bot (Jenkins) (Code Review)