Change in coreboot[master]: drivers/intel/fsp2_0: add warning when ADD_FSP_BINARIES isn't selected - coreboot-gerrit

5 Sep 2021


      Attention is currently required from: Nico Huber, Andrey Petrov, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57368 )
Change subject: drivers/intel/fsp2_0: add warning when ADD_FSP_BINARIES isn't selected
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/57368/comment/04fa2370_b816e641 
PS1, Line 121: likely won't boot\n"
             : 	printf "successfully
...
I guess we know for sure that it won't boot without the blobs, so how about: […]
good point; changed this in patchset 2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57368
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6efc184ecc4059818474937fd31574f703c9bdc6
Gerrit-Change-Number: 57368
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sun, 05 Sep 2021 17:59:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment