Attention is currently required from: Hung-Te Lin, Jes Klinke, Patrick Rudolph. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62278 )
Change subject: i2c: Configurable I2C transfer timeout ......................................................................
Patch Set 7:
(1 comment)
File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/62278/comment/b9cfd818_0ebcf450 PS7, Line 242: CONFIG_I2C_TRANSFER_TIMEOUT_US
Just saw Julius' comment about (transfer timeout) "but that's the one really generic kind of timeout […]
I would suggest we change all affected timeouts to the new default unless someone has an explicit reason why the timeout for some board should be different. Usually people just make a random high-sounding number for these timeouts when writing an I2C driver, because they don't get hit under normal operation anyway. They just need to be "high enough", and 500ms is pretty high. So I think we should discourage platforms from all making up their own thing here unless they have an explicit, documented reason.
-
Julius Werner (Code Review)