Change in coreboot[master]: Revert "include/cpu/x86: Add STM Support"

[Aaron Durbin (Code Review)]

Hello ron minnich, Name of user not set #1002358, build bot (Jenkins), Martin Roth, Patrick Georgi, Furquan Shaikh,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/37096

to review the following change.

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Revert "include/cpu/x86: Add STM Support"

This reverts commit 297b6b862a724de70abf33f681f63b6a3d84c24b.

Reason for revert: breaks smm. No code is using these fields. Original patch incomplete.

Change-Id: I6acf15dc9d77ed8a83b98f086f2a0b306c584a9b
---
M src/include/cpu/x86/msr.h
M src/include/cpu/x86/smm.h
2 files changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/37096/1

diff --git a/src/include/cpu/x86/msr.h b/src/include/cpu/x86/msr.h
index 0da8b56..2710e7f 100644
--- a/src/include/cpu/x86/msr.h
+++ b/src/include/cpu/x86/msr.h
@@ -30,10 +30,6 @@
 #define IA32_BIOS_SIGN_ID		0x8b
 #define IA32_MPERF			0xe7
 #define IA32_APERF			0xe8
-/* STM */
-#define IA32_SMM_MONITOR_CTL_MSR        0x9B
-#define SMBASE_RO_MSR			0x98
-#define IA32_SMM_MONITOR_VALID          (1<<0)
 #define IA32_MCG_CAP			0x179
 #define  MCG_CTL_P			(1 << 3)
 #define  MCA_BANKS_MASK			0xff
@@ -52,8 +48,6 @@
 #define IA32_PAT			0x277
 #define IA32_MC0_CTL			0x400
 #define IA32_MC0_STATUS			0x401
-#define IA32_VMX_BASIC_MSR              0x480
-#define IA32_VMX_MISC_MSR               0x485
 #define  MCA_STATUS_HI_VAL		(1UL << (63 - 32))
 #define  MCA_STATUS_HI_OVERFLOW		(1UL << (62 - 32))
 #define  MCA_STATUS_HI_UC		(1UL << (61 - 32))
diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h
index 9efe2e0..cf107b1 100644
--- a/src/include/cpu/x86/smm.h
+++ b/src/include/cpu/x86/smm.h
@@ -64,9 +64,6 @@
 struct smm_runtime {
    u32 smbase;
    u32 save_state_size;
-	u32 num_cpus;
-	/* STM's 32bit entry into SMI handler */
-	u32 start32_offset;
    /* The apic_id_to_cpu provides a mapping from APIC id to CPU number.
     * The CPU number is indicated by the index into the array by matching
     * the default APIC id and value at the index. The stub loader

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37096 )

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37096 )

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37096 )

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Patch Set 1: Code-Review+2

needs Signed-off-by

[Aaron Durbin (Code Review)]

Hello Kyösti Mälkki, ron minnich, Name of user not set #1002358, build bot (Jenkins), Nico Huber, Furquan Shaikh, Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37096

to look at the new patch set (#2).

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Revert "include/cpu/x86: Add STM Support"

This reverts commit 297b6b862a724de70abf33f681f63b6a3d84c24b.

Reason for revert: breaks smm. No code is using these fields. Original patch incomplete.

Change-Id: I6acf15dc9d77ed8a83b98f086f2a0b306c584a9b
Signed-off-by: Aaron Durbin 
---
M src/include/cpu/x86/msr.h
M src/include/cpu/x86/smm.h
2 files changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/37096/2

[ron minnich (Code Review)]

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37096 )

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Patch Set 3: Code-Review+2

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37096 )

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Patch Set 3: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37096 )

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Patch Set 3: Code-Review+2

[Matt DeVillier (Code Review)]

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37096 )

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Revert "include/cpu/x86: Add STM Support"

This reverts commit 297b6b862a724de70abf33f681f63b6a3d84c24b.

Reason for revert: breaks smm. No code is using these fields. Original patch incomplete.

Change-Id: I6acf15dc9d77ed8a83b98f086f2a0b306c584a9b
Signed-off-by: Aaron Durbin 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37096
Reviewed-by: ron minnich 
Reviewed-by: Werner Zeh 
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins) 
---
M src/include/cpu/x86/msr.h
M src/include/cpu/x86/smm.h
2 files changed, 0 insertions(+), 9 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  ron minnich: Looks good to me, approved
  Werner Zeh: Looks good to me, approved

diff --git a/src/include/cpu/x86/msr.h b/src/include/cpu/x86/msr.h
index 0da8b56..2710e7f 100644
--- a/src/include/cpu/x86/msr.h
+++ b/src/include/cpu/x86/msr.h
@@ -30,10 +30,6 @@
 #define IA32_BIOS_SIGN_ID		0x8b
 #define IA32_MPERF			0xe7
 #define IA32_APERF			0xe8
-/* STM */
-#define IA32_SMM_MONITOR_CTL_MSR        0x9B
-#define SMBASE_RO_MSR			0x98
-#define IA32_SMM_MONITOR_VALID          (1<<0)
 #define IA32_MCG_CAP			0x179
 #define  MCG_CTL_P			(1 << 3)
 #define  MCA_BANKS_MASK			0xff
@@ -52,8 +48,6 @@
 #define IA32_PAT			0x277
 #define IA32_MC0_CTL			0x400
 #define IA32_MC0_STATUS			0x401
-#define IA32_VMX_BASIC_MSR              0x480
-#define IA32_VMX_MISC_MSR               0x485
 #define  MCA_STATUS_HI_VAL		(1UL << (63 - 32))
 #define  MCA_STATUS_HI_OVERFLOW		(1UL << (62 - 32))
 #define  MCA_STATUS_HI_UC		(1UL << (61 - 32))
diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h
index 9efe2e0..cf107b1 100644
--- a/src/include/cpu/x86/smm.h
+++ b/src/include/cpu/x86/smm.h
@@ -64,9 +64,6 @@
 struct smm_runtime {
    u32 smbase;
    u32 save_state_size;
-	u32 num_cpus;
-	/* STM's 32bit entry into SMI handler */
-	u32 start32_offset;
    /* The apic_id_to_cpu provides a mapping from APIC id to CPU number.
     * The CPU number is indicated by the index into the array by matching
     * the default APIC id and value at the index. The stub loader

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37096 )

Change subject: Revert "include/cpu/x86: Add STM Support"
......................................................................

Patch Set 4: Code-Review+2