Attention is currently required from: Raul Rangel, Karthik Ramasubramanian.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62443 )
Change subject: mb/google/zork: fix SMMSTORE size, alignment in default FMAP
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62443/comment/0e1144bc_f30acc7d
PS1, Line 12: asserts
Which asserts?
src/drivers/smmstore/store.c lines 15 and 18
File src/mainboard/google/zork/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/62443/comment/0546b0d8_7c56eab7
PS1, Line 15: RW_ELOG(PRESERVE) 4K
: RW_SHARED 16K {
: SHARED_DATA 8K
: VBLOCK_DEV 8K
: }
: RW_VPD(PRESERVE) 8K
: RW_NVRAM(PRESERVE) 20K
This is going to invalidate all this data. […]
sure, I Will do that instead
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62443
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied04e93379e1507f5e6b2a1b71e4098a4561e5d8
Gerrit-Change-Number: 62443
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 02 Mar 2022 15:51:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment