Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29469 )
Change subject: mb/google/kahlee: edp panel initialization time tuning ......................................................................
Patch Set 6:
(5 comments)
Sorry I did not noticed the other issues in the commit message... The explanation on commit message is now clear, thanks.
https://review.coreboot.org/#/c/29469/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@7 PS6, Line 7: e Capital letter
https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@9 PS6, Line 9: a Capital letter
https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@12 PS6, Line 12: t Capital letter
https://review.coreboot.org/#/c/29469/6//COMMIT_MSG@17 PS6, Line 17: emerge-grunt coreboot Add a dot to the end.
https://review.coreboot.org/#/c/29469/6/src/soc/amd/stoneyridge/chip.h File src/soc/amd/stoneyridge/chip.h:
https://review.coreboot.org/#/c/29469/6/src/soc/amd/stoneyridge/chip.h@67 PS6, Line 67: * This specifies the LVDS/eDP power up sequence time for the delay from : * active to active. : * 0 - Use the VBIOS default (default). The video BIOS default is 32ms. : * n - Values other than zero specify a setting of (4 * n) milliseconds : * time delay. : Nice, I like it.
-
Richard Spiegel (Code Review)