Attention is currently required from: Paul Menzel, Yidi Lin, cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74084 )
Change subject: drivers/mipi: Add support for STA_HIMAX83102_J02 panel
......................................................................
Patch Set 13:
(2 comments)
This change is ready for review.
File src/drivers/mipi/Kconfig:
https://review.coreboot.org/c/coreboot/+/74084/comment/1cdd6e13_09784e44
PS6, Line 45: config MIPI_PANEL_STA_HIMAX83102_J02
According to the sort command, the original order should be correct.
Done
File src/drivers/mipi/panel-STA_HIMAX83102_J02.c:
https://review.coreboot.org/c/coreboot/+/74084/comment/63cda4db_24efd156
PS12, Line 7: HFH036009-53G
Why is this string not HIMAX83102_J02 or HIMAX83102-J02?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74084
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I382bdc89e5a217fd1c28e677938f454dc09725cc
Gerrit-Change-Number: 74084
Gerrit-PatchSet: 13
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Sat, 29 Apr 2023 06:12:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment