Change in ...coreboot[master]: src/mainboard/asus/am1i-a/buildOpts.c: improve the RAM frequency rela...
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33920
Change subject: src/mainboard/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
src/mainboard/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines
This improvement is likely required for forcing a pair of 1866MHz CL9 RAM sticks to work faster than a mediocre 1333MHz CL9, but sadly alone it's not enough... Still it doesn't bring any downsides to a system operation, just no upsides yet.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ib2bc605b98ad99066549017697bb483ad3be3910 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/33920/1
diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c index 98bc620..48c5c56 100644 --- a/src/mainboard/asus/am1i-a/buildOpts.c +++ b/src/mainboard/asus/am1i-a/buildOpts.c @@ -117,22 +117,22 @@
#define BLDCFG_AMD_PLATFORM_TYPE AMD_PLATFORM_DESKTOP
-#define BLDCFG_MEMORY_BUS_FREQUENCY_LIMIT DDR1600_FREQUENCY +#define BLDCFG_MEMORY_BUS_FREQUENCY_LIMIT DDR1866_FREQUENCY #define BLDCFG_MEMORY_MODE_UNGANGED TRUE #define BLDCFG_MEMORY_QUAD_RANK_CAPABLE TRUE #define BLDCFG_MEMORY_QUADRANK_TYPE QUADRANK_UNBUFFERED #define BLDCFG_MEMORY_RDIMM_CAPABLE TRUE #define BLDCFG_MEMORY_UDIMM_CAPABLE TRUE #define BLDCFG_MEMORY_SODIMM_CAPABLE FALSE -#define BLDCFG_MEMORY_ENABLE_BANK_INTERLEAVING FALSE -#define BLDCFG_MEMORY_ENABLE_NODE_INTERLEAVING FALSE -#define BLDCFG_MEMORY_CHANNEL_INTERLEAVING FALSE +#define BLDCFG_MEMORY_ENABLE_BANK_INTERLEAVING TRUE +#define BLDCFG_MEMORY_ENABLE_NODE_INTERLEAVING TRUE +#define BLDCFG_MEMORY_CHANNEL_INTERLEAVING TRUE #define BLDCFG_MEMORY_POWER_DOWN TRUE #define BLDCFG_POWER_DOWN_MODE POWER_DOWN_BY_CHIP_SELECT #define BLDCFG_ONLINE_SPARE FALSE #define BLDCFG_BANK_SWIZZLE TRUE #define BLDCFG_TIMING_MODE_SELECT TIMING_MODE_AUTO -#define BLDCFG_MEMORY_CLOCK_SELECT DDR1333_FREQUENCY +#define BLDCFG_MEMORY_CLOCK_SELECT DDR1866_FREQUENCY #define BLDCFG_DQS_TRAINING_CONTROL TRUE #define BLDCFG_IGNORE_SPD_CHECKSUM TRUE #define BLDCFG_USE_BURST_MODE FALSE
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: src/mainboard/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 1:
am1i-a/buildOpts.c patch series [8/8] : 1st = CB:33913 , 2nd = CB:33914 , 3rd = CB:33915 , 4th = CB:33916 , 5th = CB:33917 , 6th = CB:33918 , 7th = CB:33919 ; 8th = CB:33920 <-- you are here
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: src/mainboard/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 1:
Friends, please review this patch series, and - if you have some ideas why this is not enough to get a pair of 1866MHz CL9 RAM modules* to work faster than 1333MHz CL9 - please tell ! They're working fast with a proprietary UEFI, and I hope to achieve the same results with coreboot.
* Crucial Ballistix Tactical Series DDR3 1866MHz CL9 (PC3-14900 9-9-9-24) UDIMM 240-Pin modules, part number BLT8G3D1869DT1TX0
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: src/mainboard/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 1:
Hope you could take a look at a problem described one comment above - that's a main reason why I've done this patch series
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: src/mainboard/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33920/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33920/4//COMMIT_MSG@6 PS4, Line 6: : src/mainboard mb
Hello build bot (Jenkins), Paul Menzel, Angel Pons, Gergely Kiss, Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33920
to look at the new patch set (#6).
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines
This improvement is likely required for forcing a pair of 1866MHz CL9 RAM sticks to work faster than a mediocre 1333MHz CL9, but sadly alone it's not enough... Still it doesn't bring any downsides to a system operation, just no upsides yet.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ib2bc605b98ad99066549017697bb483ad3be3910 --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/33920/6
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33920/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33920/4//COMMIT_MSG@6 PS4, Line 6: : src/mainboard
mb
Done. If I succeed at adding the XMP support to coreboot's AGESA, this commit series could be useful.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 6:
Different SHA256 as expected.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 6:
buildOpts.c result of changes 33913-33920 as of 09 April 2020 - https://pastebin.com/raw/UnPEPtJs , 0d5f231fdaddbed8b7b7d55ff11d4533a020009e1ce9e0fbc106067ddfda5508 ./src/mainboard/asus/am1i-a/buildOpts.c
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33920/6/src/mainboard/asus/am1i-a/b... File src/mainboard/asus/am1i-a/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/33920/6/src/mainboard/asus/am1i-a/b... PS6, Line 107: DDR1866_FREQUENCY If you can set these while the defines are below it, it means that something else is defining these values... The `L` in `AGESA` stands for `Logical`, I guess.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33920/6/src/mainboard/asus/am1i-a/b... File src/mainboard/asus/am1i-a/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/33920/6/src/mainboard/asus/am1i-a/b... PS6, Line 107: DDR1866_FREQUENCY
If you can set these while the defines are below it, it means that something else is defining these […]
Indeed. My point is that BLDCFG_MEMORY_BUS_FREQUENCY_LIMIT DDR1600_FREQUENCY wasn't a good define to begin with, since this board could clearly go 1866MHz (tried with proprietary UEFI and it worked). Perhaps the only thing I need to change here is maybe BLDCFG_MEMORY_ENABLE_NODE_INTERLEAVING TRUE --> FALSE, to make it more similar to G505S. Need to do a lot of experiments, and hopefully CB:33913-CB:33920 series together with DDR3 XMP change CB:40291 and some magic, we could finally get it running faster than 1333MHz ;)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33920/6/src/mainboard/asus/am1i-a/b... File src/mainboard/asus/am1i-a/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/33920/6/src/mainboard/asus/am1i-a/b... PS6, Line 107: DDR1866_FREQUENCY
Indeed. […]
What I mean is that the defines below are not needed, because they are defined elsewhere (probably in some other included header). Please remove them in CB:33918
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 8:
(1 comment)
Have you tried to use AGESA IDS debugging to troubleshoot it?
https://review.coreboot.org/c/coreboot/+/33920/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33920/8//COMMIT_MSG@9 PS8, Line 9: This improvement is likely required for forcing a pair of 1866MHz CL9 RAM sticks : to work faster than a mediocre 1333MHz CL9, but sadly alone it's not enough... : Still it doesn't bring any downsides to a system operation, just no upsides yet. Please wrap at 72 characters
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Patch Set 9:
Patch Set 8:
(1 comment)
Have you tried to use AGESA IDS debugging to troubleshoot it?
Eventually I got it working, if combined with "AMD_XMP" changes ( CB:40484 , CB:40485 , CB:40488 , CB:40489 , CB:40490 ) - however, only at 1600 MHz CL8 speeds. 1866 MHz CL9 is impossible on f16kb without overclocking the northbridge / memory controller / etc., which is hardly doable because of hardcoded base clock values, "1866 MHz unsupported" bit flags that have to be overriden, and other difficulties.
1600 MHz CL8 is also a good result, I think. Much better than 1333 MHz CL9 ;-)
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33920 )
Change subject: mb/asus/am1i-a/buildOpts.c: improve the RAM frequency related defines ......................................................................
Abandoned
Superseded by CB:40493.
-
Angel Pons (Code Review) -
Michał Żygowski (Code Review)
-
Mike Banon (Code Review)