Attention is currently required from: Caveh Jalali, Paul Menzel, Tim Wawrzynczak, Rizwan Qureshi, Edward O'Callaghan, Nick Vaccaro, Alex Levin, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61849 )
Change subject: soc/intel/fast_spi: Check SPI Cycle In-Progress prior start HW Seq
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61849/comment/83d7a89b_59572643
PS2, Line 8:
Is there an actual problem, or just to confirm to the datasheet?
It's fix IMO, we are seeing some failure and figured out SPI driver is missing one important sync.
https://review.coreboot.org/c/coreboot/+/61849/comment/f1c99628_e7bd46c5
PS2, Line 20: Added
Add
Ack
https://review.coreboot.org/c/coreboot/+/61849/comment/c9082c67_d3a7ae80
PS2, Line 22:
Tested how?
Ack
File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/61849/comment/568d27d3_59aaf92e
PS2, Line 142: printk(BIOS_INFO, "SPI Transaction in progress..\n");
This might be printed a lot of times? Also, it just a debug message?
Isn't that good way to know if SPI bus is *real* busy using a debug msg ? This might be rear but still relevant ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d35058244a73e77f6204c4d04d09bae9e5ac62c
Gerrit-Change-Number: 61849
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Alex Levin
levinale@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Alex Levin
levinale@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 11 Feb 2022 12:49:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment