Attention is currently required from: Martin L Roth, Subrata Banik, Mario Scheithauer, Angel Pons, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 )
Change subject: src/device + util/sconfig: Introduce new device 'mdio'
......................................................................
Patch Set 5:
(1 comment)
File src/include/device/path.h:
https://review.coreboot.org/c/coreboot/+/69382/comment/444be0a0_c7152492
PS5, Line 117: struct mdio_path {
: unsigned int addr;
: };
Indeed gcc checks for the vaid range and complains if it does not fir:
build/mainboard/siemens/mc_ehl/static.c:1021:51: error: unsigned conversion from 'int' to 'unsigned char:5' changes value from '33' to '1' [-Werror=overflow]
.path = {.type=DEVICE_PATH_MDIO,{.mdio={ .addr = 0x21 }}},
I can push a follow-up patch once this train is in.
Cool! A follow-up is fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6691f92c4233bc30afc9029840b06f74bb1eb4b2
Gerrit-Change-Number: 69382
Gerrit-PatchSet: 5
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 11:39:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment