Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33050
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
mainboard/google/hatch: Update Helios device tree
Update Helios device tree override to match schematics.
BUG=b:133182138 BRANCH=none TEST=Compiles
Change-Id: I3d15fc43651a289d16ffb3cfadaea8f786e858fc Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 88 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/33050/1
diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 84f0e29..4fecab3 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -14,6 +14,9 @@ [PchSerialIoIndexUART2] = PchSerialIoDisabled, }"
+ # No PCIe WiFi + register "PcieRpEnable[13]" = "0" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -42,5 +45,89 @@ }, }"
- device domain 0 on end + device domain 0 on + device pci 14.0 on + chip drivers/usb/acpi + device usb 0.0 on + chip drivers/usb/acpi + # No Type-A port + device usb 2.2 off end + end + chip drivers/usb/acpi + # No Type-A Port + device usb 2.3 off end + end + chip drivers/usb/acpi + # No WWAN + device usb 2.5 off end + end + chip drivers/usb/acpi + # No WWAN + device usb 3.4 off end + end + end + end + end + + # Native SD Card interface unused + device pci 14.5 off end + + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A20_IRQ)" + register "wake" = "GPE0_DW0_21" + device i2c 15 on end + end + end + + device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "10" + register "generic.reset_off_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" + register "key.wake" = "GPE0_DW0_08" + register "key.wakeup_event_action" = "EV_ACT_ASSERTED" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on end + end + end # I2C 1 + + # I2C #2 unused + device pci 15.2 off end + + # I2C #3 unused + device pci 15.3 off end + + device pci 19.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Realtek RT5682"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_H0)" + register "property_count" = "1" + # Set the jd_src to RT5668_JD1 for jack detection + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on end + end + end #I2C #4 + end end
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 1: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33050/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/#/c/33050/3/src/mainboard/google/hatch/variants/... PS3, Line 26: I2C2 | Digitizer Update this too?
https://review.coreboot.org/#/c/33050/3/src/mainboard/google/hatch/variants/... PS3, Line 36: i2c[2] = { : .speed = I2C_SPEED_FAST, : }, And remove this?
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 3:
Can we disable SATA controller too here? Since Helios would support PCIe based storage only.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33050/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33050/3//COMMIT_MSG@9 PS3, Line 9: Update Helios device tree override to match schematics. Did something not work before?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33050/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33050/3//COMMIT_MSG@9 PS3, Line 9: Update Helios device tree override to match schematics.
Did something not work before?
No, I just started with a bare bones device tree in the first CL, and then add the rest of it in a separate one.
Hello Paul Fagerburg, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33050
to look at the new patch set (#4).
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
mainboard/google/hatch: Update Helios device tree
Update Helios device tree override to match schematics.
BUG=b:133182138 BRANCH=none TEST=Compiles
Change-Id: I3d15fc43651a289d16ffb3cfadaea8f786e858fc Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 100 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/33050/4
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 4: Code-Review+1
Hello Paul Fagerburg, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33050
to look at the new patch set (#5).
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
mainboard/google/hatch: Update Helios device tree
Update Helios device tree override to match schematics.
BUG=b:133182138 BRANCH=none TEST=Compiles
Change-Id: I3d15fc43651a289d16ffb3cfadaea8f786e858fc Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 100 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/33050/5
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/33050/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/#/c/33050/3/src/mainboard/google/hatch/variants/... PS3, Line 26: I2C2 | Digitizer
Update this too?
Done
https://review.coreboot.org/#/c/33050/3/src/mainboard/google/hatch/variants/... PS3, Line 36: i2c[2] = { : .speed = I2C_SPEED_FAST, : },
And remove this?
Done
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 5: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 5: Code-Review+2
Hello Paul Fagerburg, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33050
to look at the new patch set (#7).
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
mainboard/google/hatch: Update Helios device tree
Update Helios device tree override to match schematics.
BUG=b:133182138 BRANCH=none TEST=Compiles
Change-Id: I3d15fc43651a289d16ffb3cfadaea8f786e858fc Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 88 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/33050/7
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 7: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
Patch Set 7: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33050 )
Change subject: mainboard/google/hatch: Update Helios device tree ......................................................................
mainboard/google/hatch: Update Helios device tree
Update Helios device tree override to match schematics.
BUG=b:133182138 BRANCH=none TEST=Compiles
Change-Id: I3d15fc43651a289d16ffb3cfadaea8f786e858fc Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/33050 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/helios/overridetree.cb 1 file changed, 88 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 84f0e29..405f85f 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -14,13 +14,15 @@ [PchSerialIoIndexUART2] = PchSerialIoDisabled, }"
+ # No PCIe WiFi + register "PcieRpEnable[13]" = "0" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | #+-------------------+---------------------------+ #| I2C0 | Trackpad | #| I2C1 | Touchscreen | - #| I2C2 | Digitizer | #| I2C4 | Audio | #+-------------------+---------------------------+ register "common_soc_config" = "{ @@ -30,9 +32,6 @@ .i2c[1] = { .speed = I2C_SPEED_FAST, }, - .i2c[2] = { - .speed = I2C_SPEED_FAST, - }, .i2c[4] = { .speed = I2C_SPEED_FAST, }, @@ -42,5 +41,89 @@ }, }"
- device domain 0 on end + device domain 0 on + device pci 14.0 on + chip drivers/usb/acpi + device usb 0.0 on + chip drivers/usb/acpi + # No Type-A port + device usb 2.2 off end + end + chip drivers/usb/acpi + # No Type-A Port + device usb 2.3 off end + end + chip drivers/usb/acpi + # No WWAN + device usb 2.5 off end + end + chip drivers/usb/acpi + # No WWAN + device usb 3.4 off end + end + end + end + end + + # Native SD Card interface unused + device pci 14.5 off end + + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A20_IRQ)" + register "wake" = "GPE0_DW0_21" + device i2c 15 on end + end + end + + device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "10" + register "generic.reset_off_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" + register "key.wake" = "GPE0_DW0_08" + register "key.wakeup_event_action" = "EV_ACT_ASSERTED" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on end + end + end # I2C 1 + + # I2C #2 unused + device pci 15.2 off end + + # I2C #3 unused + device pci 15.3 off end + + device pci 19.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Realtek RT5682"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_H0)" + register "property_count" = "1" + # Set the jd_src to RT5668_JD1 for jack detection + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on end + end + end #I2C #4 + end end
-
Aamir Bohra (Code Review) -
Furquan Shaikh (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)