Attention is currently required from: Michał Żygowski, Maulik V Vaghela, Jeremy Soller, Tim Wawrzynczak, Paul Menzel, Ronak Kanabar.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64074 )
Change subject: soc/intel/alderlake/hsphy: Add support for HSPHY firmware loading
......................................................................
Patch Set 4:
(4 comments)
File src/soc/intel/alderlake/hsphy.c:
https://review.coreboot.org/c/coreboot/+/64074/comment/4835a0d5_594257bd
PS2, Line 172: hexdump(hash_buf, hash_size);
suggestion: add headers before the hexdumps, like 'hash from CSE', and 'calculated hash' ?
Added headers
https://review.coreboot.org/c/coreboot/+/64074/comment/c0bde600_8ff505ac
PS2, Line 188: {
: break; // End of file
: }
{} not necessary
Removed
https://review.coreboot.org/c/coreboot/+/64074/comment/dc3b5a18_b9afd157
PS2, Line 275:
extra tab
Removed
https://review.coreboot.org/c/coreboot/+/64074/comment/51bc9d1c_d35e059b
PS2, Line 301:
nit: extra blank line
Removed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64074
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c6c11581e3d3d9bab0131fae6ef487cafe98080
Gerrit-Change-Number: 64074
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:03:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment