Attention is currently required from: Eric Lai, Julius Werner, Kapil Porwal, Shelley Chen, Subrata Banik, Tim Van Patten.
Hello Eric Lai, Julius Werner, Kapil Porwal, Shelley Chen, Tim Van Patten, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79769?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Code-Review+2 by Julius Werner, Code-Review+2 by Tim Van Patten, Verified+1 by build bot (Jenkins)
Change subject: vendorcode/google/chromeos: Use unsigned int for "factory_config" ......................................................................
vendorcode/google/chromeos: Use unsigned int for "factory_config"
This patch ensures `chromeos_get_factory_config()` returns an unsigned integer value because factory config represents bit-fields to determine the Chromebook Plus branding.
Additionally, introduced safety measures to catch future "factory_config" bit-field exhaustion.
BUG=b:317880956 TEST=Able to verify that google/screebo is branded as Chromebook Plus.
Change-Id: I3021b8646de4750b4c8e2a2981f42500894fa2d0 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/vendorcode/google/chromeos/chromeos.h M src/vendorcode/google/chromeos/tpm_factory_config.c 2 files changed, 15 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/79769/4