Attention is currently required from: Eric Lai, Julius Werner, Kapil Porwal, Shelley Chen, Subrata Banik, Tim Van Patten.

Subrata Banik uploaded patch set #4 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+2 by Julius Werner, Code-Review+2 by Tim Van Patten, Verified+1 by build bot (Jenkins)

vendorcode/google/chromeos: Use unsigned int for "factory_config"

This patch ensures `chromeos_get_factory_config()` returns an
unsigned integer value because factory config represents
bit-fields to determine the Chromebook Plus branding.

Additionally, introduced safety measures to catch future
"factory_config" bit-field exhaustion.

BUG=b:317880956
TEST=Able to verify that google/screebo is branded as
Chromebook Plus.

Change-Id: I3021b8646de4750b4c8e2a2981f42500894fa2d0
Signed-off-by: Subrata Banik <subratabanik@google.com>
---
M src/vendorcode/google/chromeos/chromeos.h
M src/vendorcode/google/chromeos/tpm_factory_config.c
2 files changed, 15 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/79769/4

To view, visit change 79769. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3021b8646de4750b4c8e2a2981f42500894fa2d0
Gerrit-Change-Number: 79769
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Tim Van Patten <timvp@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Shelley Chen <shchen@google.com>
Gerrit-Attention: Eric Lai <ericllai@google.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: Tim Van Patten <timvp@google.com>
Gerrit-MessageType: newpatchset