Attention is currently required from: Bao Zheng, Jason Glenesk, Matt DeVillier, Zheng Bao, Karthik Ramasubramanian, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72703 )
Change subject: soc/amd/phoenix: Allow the amdfw.rom to be split into two parts
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
Patchset:
PS6:
That's a good idea - I'll look into moving the larger EC FW blob to an FMAP region in the upper 16M
I tested moving the Birman EC blob to the upper 16M but it did not work. I will keep the EC blobs in the lower 16M for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8b318f71632a2c9b97ce67486374dc24d23e63e
Gerrit-Change-Number: 72703
Gerrit-PatchSet: 9
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 01 Mar 2023 18:48:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment