Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45826 )
Change subject: soc/intel/icl: enable common CPU code ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45826/2/src/soc/intel/icelake/romst... File src/soc/intel/icelake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45826/2/src/soc/intel/icelake/romst... PS2, Line 59: m_cfg->VmxEnable = CONFIG(ENABLE_VMX);
always call the lock when fsp already locks it? I don't think we want this duplication
Better than yet another `if`?