[M] Change in coreboot[main]: drivers/lenovo/hybrid_graphics/chip: Use boolean when appropriate
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86610?usp=email )
Change subject: drivers/lenovo/hybrid_graphics/chip: Use boolean when appropriate ......................................................................
drivers/lenovo/hybrid_graphics/chip: Use boolean when appropriate
Change-Id: I1f456765eb60b8ad1e680255b50abad5dea8252c Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/drivers/lenovo/hybrid_graphics/chip.h M src/mainboard/lenovo/t400/variants/t400/overridetree.cb M src/mainboard/lenovo/t410/devicetree.cb M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t520/devicetree.cb M src/mainboard/lenovo/t530/devicetree.cb 8 files changed, 45 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/86610/1
diff --git a/src/drivers/lenovo/hybrid_graphics/chip.h b/src/drivers/lenovo/hybrid_graphics/chip.h index b3ea2b6..4a17138 100644 --- a/src/drivers/lenovo/hybrid_graphics/chip.h +++ b/src/drivers/lenovo/hybrid_graphics/chip.h @@ -23,19 +23,19 @@ struct drivers_lenovo_hybrid_graphics_config { unsigned int detect_gpio;
- unsigned int has_panel_hybrid_gpio; + bool has_panel_hybrid_gpio; unsigned int panel_hybrid_gpio; - unsigned int panel_integrated_lvl; + bool panel_integrated_lvl;
- unsigned int has_backlight_gpio; + bool has_backlight_gpio; unsigned int backlight_gpio; - unsigned int backlight_integrated_lvl; + bool backlight_integrated_lvl;
- unsigned int has_dgpu_power_gpio; + bool has_dgpu_power_gpio; unsigned int dgpu_power_gpio; - unsigned int dgpu_power_off_lvl; + bool dgpu_power_off_lvl;
- unsigned int has_thinker1; + bool has_thinker1; };
#endif /* _LENOVO_HYBRID_GRAPHICS_CHIP_H_ */ diff --git a/src/mainboard/lenovo/t400/variants/t400/overridetree.cb b/src/mainboard/lenovo/t400/variants/t400/overridetree.cb index a1b4f9d..c3c3b08 100644 --- a/src/mainboard/lenovo/t400/variants/t400/overridetree.cb +++ b/src/mainboard/lenovo/t400/variants/t400/overridetree.cb @@ -8,17 +8,17 @@
register "detect_gpio" = "21"
- register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "22" - register "panel_integrated_lvl" = "0" + register "panel_integrated_lvl" = "false"
- register "has_backlight_gpio" = "1" + register "has_backlight_gpio" = "true" register "backlight_gpio" = "19" - register "backlight_integrated_lvl" = "0" + register "backlight_integrated_lvl" = "false"
- register "has_dgpu_power_gpio" = "1" + register "has_dgpu_power_gpio" = "true" register "dgpu_power_gpio" = "49" - register "dgpu_power_off_lvl" = "0" + register "dgpu_power_off_lvl" = "false"
register "has_thinker1" = "0" end diff --git a/src/mainboard/lenovo/t410/devicetree.cb b/src/mainboard/lenovo/t410/devicetree.cb index 1ef7075..9ba70d7 100644 --- a/src/mainboard/lenovo/t410/devicetree.cb +++ b/src/mainboard/lenovo/t410/devicetree.cb @@ -138,19 +138,19 @@
register "detect_gpio" = "21"
- register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true"
- register "has_backlight_gpio" = "1" + register "has_backlight_gpio" = "true" register "backlight_gpio" = "50" - register "backlight_integrated_lvl" = "0" + register "backlight_integrated_lvl" = "false"
- register "has_dgpu_power_gpio" = "1" + register "has_dgpu_power_gpio" = "true" register "dgpu_power_gpio" = "49" - register "dgpu_power_off_lvl" = "0" + register "dgpu_power_off_lvl" = "false"
- register "has_thinker1" = "1" + register "has_thinker1" = "true" end end device pci 1f.2 on # IDE/SATA diff --git a/src/mainboard/lenovo/t420/devicetree.cb b/src/mainboard/lenovo/t420/devicetree.cb index 65891f0..f5272fc 100644 --- a/src/mainboard/lenovo/t420/devicetree.cb +++ b/src/mainboard/lenovo/t420/devicetree.cb @@ -158,14 +158,14 @@
register "detect_gpio" = "21"
- register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true"
- register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false"
- register "has_thinker1" = "1" + register "has_thinker1" = "true" end end # LPC Controller device ref sata1 on end # 6 port SATA AHCI Controller diff --git a/src/mainboard/lenovo/t420s/devicetree.cb b/src/mainboard/lenovo/t420s/devicetree.cb index b358885..840e520 100644 --- a/src/mainboard/lenovo/t420s/devicetree.cb +++ b/src/mainboard/lenovo/t420s/devicetree.cb @@ -150,14 +150,14 @@
register "detect_gpio" = "21"
- register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true"
- register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false"
- register "has_thinker1" = "1" + register "has_thinker1" = "true" end end # LPC Controller device ref sata1 on end # 6 port SATA AHCI Controller diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index 89dcf97..9a0db4d 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -131,14 +131,14 @@
register "detect_gpio" = "21"
- register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true"
- register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false"
- register "has_thinker1" = "1" + register "has_thinker1" = "true" end chip drivers/pc80/tpm device pnp 0c31.0 on end diff --git a/src/mainboard/lenovo/t520/devicetree.cb b/src/mainboard/lenovo/t520/devicetree.cb index c404df2..7102df0 100644 --- a/src/mainboard/lenovo/t520/devicetree.cb +++ b/src/mainboard/lenovo/t520/devicetree.cb @@ -146,14 +146,14 @@
register "detect_gpio" = "21"
- register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true"
- register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false"
- register "has_thinker1" = "1" + register "has_thinker1" = "true" end end device ref sata1 on end diff --git a/src/mainboard/lenovo/t530/devicetree.cb b/src/mainboard/lenovo/t530/devicetree.cb index 305a47e..362e0a6 100644 --- a/src/mainboard/lenovo/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/devicetree.cb @@ -126,14 +126,14 @@
register "detect_gpio" = "21"
- register "has_panel_hybrid_gpio" = "1" + register "has_panel_hybrid_gpio" = "true" register "panel_hybrid_gpio" = "52" - register "panel_integrated_lvl" = "1" + register "panel_integrated_lvl" = "true"
- register "has_backlight_gpio" = "0" - register "has_dgpu_power_gpio" = "0" + register "has_backlight_gpio" = "false" + register "has_dgpu_power_gpio" = "false"
- register "has_thinker1" = "1" + register "has_thinker1" = "true" end end device ref sata1 on end
-
Elyes Haouas (Code Review)