[S] Change in coreboot[main]: vc/edk2-stable202302: Add config guards to support FSP 2.4

[Appukuttan V K (Code Review)]

Attention is currently required from: Ronak Kanabar, Subrata Banik.

Appukuttan V K has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82425?usp=email )

Change subject: vc/edk2-stable202302: Add config guards to support FSP 2.4
......................................................................

Patch Set 23:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/82425/comment/2d4cfaf6_626a989c?usp... :
PS23, Line 16: - Guard x86_32 architecture specific structures under
             :   PLATFORM_USES_FSP2_X86_32 config.
             : - Guard FSP 2.4 specific structures under PLATFORM_USES_FSP2_4
             :   config.
> how do EDK2 manages to support 32-bit and/or 64-bit boot loader so far w/o the specific guard ?

I guess the problem coming since we are using 2.3 for x32 and 2.4 for x64 build. 
We might need to relook how x32 and FSP2.4 guards used within coreboot. Let me get few more information.

https://review.coreboot.org/c/coreboot/+/82425/comment/7313d4bc_413cf053?usp... :
PS23, Line 16: - Guard x86_32 architecture specific structures under
             :   PLATFORM_USES_FSP2_X86_32 config.
             : - Guard FSP 2.4 specific structures under PLATFORM_USES_FSP2_4
             :   config.
> how do EDK2 manages to support 32-bit and/or 64-bit boot loader so far w/o the specific guard ?

I guess the problem that we are using FSP2.3 for x32 and FSP2.4 for x64. If both are using 2.4 version this  issue should not come.

File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h:

https://review.coreboot.org/c/coreboot/+/82425/comment/cfab6696_05779228?usp... :
PS23, Line 382: } FSPT_UPD_COMMON_FSP24;
> this also should be guarded with `PLATFORM_USES_FSP2_4`

FSPT is not used anywhere so it is not causing any issue. Do you want to guard this anyway.

https://review.coreboot.org/c/coreboot/+/82425/comment/b1b1b196_32eef6e8?usp... :
PS23, Line 382: } FSPT_UPD_COMMON_FSP24;
> this also should be guarded with `PLATFORM_USES_FSP2_4`

FSPT is not used anywhere so it is not causing any build issue. Do you want to guard this anyway?