[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Put options in CFR cbtable

[Angel Pons (Code Review)]

Attention is currently required from: Sean Rhodes, Benjamin Doron, Christian Walter, Maximilian Brune, Lean Sheng Tan.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 )

Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable
......................................................................

Patch Set 3:

(5 comments)

File src/mainboard/prodrive/atlas/cfr.c:

https://review.coreboot.org/c/coreboot/+/74122/comment/bd5291ac_457aaeaf 
PS1, Line 14: struct sm_enum_value pwr_after_g3_values[] = {
            : 		{ "Power on (S0)",  0 },
            : 		{ "Power off (S5)", 1 },
            : 		SM_ENUM_VALUE_END,
            : 	};
> The string<->enum are still mismatched?

*facepalm*

Done

File src/mainboard/prodrive/atlas/cfr.c:

https://review.coreboot.org/c/coreboot/+/74122/comment/65125d18_72a9700e 
PS2, Line 123: 			.ui_helptext	= "Specify what to do when power is re-applied "
             : 					  "after a power loss. This option has no effect "
             : 					  "on systems without a RTC battery.", /* TODO: check */
             :
> Will try

Done

File src/mainboard/prodrive/atlas/cfr.c:

https://review.coreboot.org/c/coreboot/+/74122/comment/dfff5a73_708d1d7e 
PS3, Line 77: 			.opt_name	= "DONOTSTOREME_sn", /* TODO: Make optional? */
> Name still needed so that the value can be read.

Done

https://review.coreboot.org/c/coreboot/+/74122/comment/8540c6b9_e699123d 
PS3, Line 79: 			.flags		= CFR_OPTFLAG_READONLY,
> Add another flag to indicate an option is volatile.

Done

https://review.coreboot.org/c/coreboot/+/74122/comment/022bdc54_0d67f523 
PS3, Line 92: 			.ui_name	= "", /* Empty UI name */
> Define new tag for text fields (i.e. […]

Done