Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/20501 )
Change subject: mainboard/hp: Add HP Elitebook 8460p ......................................................................
Patch Set 6:
(3 comments)
With that fixed all boards seem ready to be pushed.
https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb File src/mainboard/hp/8460p/devicetree.cb:
https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb... PS6, Line 17: chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did remove all FIXMEs
https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb... PS6, Line 18: register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }" last two elements can be removed ad gfx.ndid is 3
https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c File src/mainboard/hp/8460p/romstage.c:
https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c@34 PS6, Line 34: { On Ivybridge I've done: RCBA32(FD) = PCH_DISABLE_ALWAYS | 0x10001fe0; Bits that should be always disabled + reserved bits. Applies to all boards.
-
Patrick Rudolph (Code Review)