[S] Change in coreboot[main]: superio/nuvoton/nct6779d: Add power_on_after_fail support - coreboot-gerrit

13 Apr 2024


      Attention is currently required from: Keith Hui.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81883?usp=email )
Change subject: superio/nuvoton/nct6779d: Add power_on_after_fail support
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: 
We could also make it a common function for Nuvoton SIOs?
File src/superio/nuvoton/nct6779d/superio.c:
https://review.coreboot.org/c/coreboot/+/81883/comment/2f01506d_1f85abe9 :
PS1, Line 37: 		 */
Same for the `cmos.layout` in case it's used. Not sure if it's worth that
much commentary only to avoid two lines of code?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81883?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia08cf8daac971397e832996ed364d41e9e7b1c5d
Gerrit-Change-Number: 81883
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Comment-Date: Sat, 13 Apr 2024 10:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment