Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29897 )
Change subject: util/inteltool: Add Apollo Lake GPIO groups and names ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
+2 to Felix' changes
https://review.coreboot.org/#/c/29897/2/util/inteltool/gpio_groups.c File util/inteltool/gpio_groups.c:
https://review.coreboot.org/#/c/29897/2/util/inteltool/gpio_groups.c@119 PS2, Line 119: "CNV_BRI_DT", "*GPIO_216", "n/a", "n/a", "n/a", "n/a",
How did you find out that this pad belongs to GPIO_216 from the GPIO multiplexing table (p. […]
Table 2-34, Community Offset column
https://review.coreboot.org/#/c/29897/2/util/inteltool/gpio_groups.c@120 PS2, Line 120: "CNV_BRI_RSP", "*GPIO_217", "n/a", "n/a", "n/a", "n/a",
Same here
Done
https://review.coreboot.org/#/c/29897/2/util/inteltool/gpio_groups.c@121 PS2, Line 121: "CNV_RGI_DT", "*GPIO_218", "n/a", "n/a", "n/a", "n/a",
Same here
Done
-
Nico Huber (Code Review)