Attention is currently required from: Martin L Roth, Jason Nien, Matt DeVillier, Arthur Heymans, Martin Roth.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73294 )
Change subject: mb/google/skyrim: Allow port descriptors to be overridden
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/73294/comment/b9d89484_f6dc7cd0
PS2, Line 97: if (!*dxio_num || !*dxio_descs)
: {
: *dxio_descs = skyrim_mdn_dxio_descriptors;
: *dxio_num = ARRAY_SIZE(skyrim_mdn_dxio_descriptors);
: }
No, it the compiler won't optimize it out and it won't drop the table above either which is a bigger […]
Why can't variant instead use the same table and update any of the descriptor elements - eg. https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/hea...
That way we dont need 2 tables and just operate on a single table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cff44f5b39d130a7191a69970cae8a88bb5d475
Gerrit-Change-Number: 73294
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 06 Mar 2023 20:00:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment