build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62091 )
Change subject: northbridge/amd/amdfam10/bootblock.c: Get rid of preprocessor IFs ......................................................................
Patch Set 1:
(10 comments)
File src/northbridge/amd/amdfam10/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/1d8371ec_4002371c PS1, Line 108: if (next_unitid >= 0x18) { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/548f9cb2_e8fa00e7 PS1, Line 109: if (!end_used) { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/fe230507_57dd60c5 PS1, Line 110: next_unitid = CONFIG_HT_CHAIN_END_UNITID_BASE; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/c64f4727_daed918e PS1, Line 112: } else { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/1a8bf3c3_bfb96a7f PS1, Line 122: if (!next_unitid) Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/3948052e_c4ffb099 PS1, Line 172: if ((ht_dev_num > 1) && trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/64eeedf9_0889f977 PS1, Line 175: flags = pci_io_read_config16(PCI_DEV(0,real_last_unitid,0), real_last_pos + PCI_CAP_FLAGS); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/f14e36e6_03ea7b7f PS1, Line 175: flags = pci_io_read_config16(PCI_DEV(0,real_last_unitid,0), real_last_pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/fbc3f083_faa2b9cf PS1, Line 175: flags = pci_io_read_config16(PCI_DEV(0,real_last_unitid,0), real_last_pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141268): https://review.coreboot.org/c/coreboot/+/62091/comment/c11f08ff_669878e7 PS1, Line 178: pci_io_write_config16(PCI_DEV(0, real_last_unitid, 0), real_last_pos + PCI_CAP_FLAGS, flags); line over 96 characters