Change in coreboot[master]: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Noibat
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42975 )
Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Noibat ......................................................................
mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Noibat
BUG=b:160296662 BRANCH=none TEST=none
Change-Id: I5298e1779461995a98722099b397692351767089 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/noibat/overridetree.cb 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/42975/1
diff --git a/src/mainboard/google/hatch/variants/noibat/overridetree.cb b/src/mainboard/google/hatch/variants/noibat/overridetree.cb index c223bb0..18f33ab 100644 --- a/src/mainboard/google/hatch/variants/noibat/overridetree.cb +++ b/src/mainboard/google/hatch/variants/noibat/overridetree.cb @@ -74,6 +74,18 @@ register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC0)" # Type-A Port 0 register "usb3_ports[5]" = "USB3_PORT_EMPTY" # Type-A Port 4
+ # Bitmap for Wake Enable on USB attach/detach + register "usb2_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(4) | \ + USB_PORT_WAKE_ENABLE(5) | \ + USB_PORT_WAKE_ENABLE(6)" + register "usb3_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(5) | \ + USB_PORT_WAKE_ENABLE(6)" + # Enable eMMC HS400 register "ScsEmmcHs400Enabled" = "1"
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42975 )
Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Noibat ......................................................................
Set Ready For Review
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42975
to look at the new patch set (#3).
Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Noibat ......................................................................
mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Noibat
BUG=b:160296662 BRANCH=none TEST=none
Change-Id: I5298e1779461995a98722099b397692351767089 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/noibat/overridetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/42975/3
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42975 )
Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Noibat ......................................................................
Patch Set 3: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42975 )
Change subject: mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Noibat ......................................................................
mb/google/hatch: Allow USB2/3 wakeups to (un)plug events in Noibat
BUG=b:160296662 BRANCH=none TEST=none
Change-Id: I5298e1779461995a98722099b397692351767089 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42975 Reviewed-by: Sam McNally sammc@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/noibat/overridetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/noibat/overridetree.cb b/src/mainboard/google/hatch/variants/noibat/overridetree.cb index c223bb0..cac7516 100644 --- a/src/mainboard/google/hatch/variants/noibat/overridetree.cb +++ b/src/mainboard/google/hatch/variants/noibat/overridetree.cb @@ -74,6 +74,16 @@ register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC0)" # Type-A Port 0 register "usb3_ports[5]" = "USB3_PORT_EMPTY" # Type-A Port 4
+ # Bitmap for Wake Enable on USB attach/detach + register "usb2_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(6)" + register "usb3_wake_enable_bitmap" = "USB_PORT_WAKE_ENABLE(1) | \ + USB_PORT_WAKE_ENABLE(2) | \ + USB_PORT_WAKE_ENABLE(3) | \ + USB_PORT_WAKE_ENABLE(5)" + # Enable eMMC HS400 register "ScsEmmcHs400Enabled" = "1"
-
Edward O'Callaghan (Code Review) -
Sam McNally (Code Review)