Change in coreboot[master]: mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41588 )

Change subject: mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL
......................................................................

mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL

This does not exist anywhere in the entire coreboot tree.

Change-Id: I80320a20f4b44896e72d701a1d98786cb3a93dcc
Signed-off-by: Angel Pons 
---
M src/mainboard/amd/olivehill/buildOpts.c
M src/mainboard/amd/parmer/buildOpts.c
M src/mainboard/amd/thatcher/buildOpts.c
M src/mainboard/asrock/imb-a180/buildOpts.c
M src/mainboard/asus/am1i-a/buildOpts.c
M src/mainboard/asus/f2a85-m/buildOpts.c
M src/mainboard/bap/ode_e20XX/buildOpts.c
M src/mainboard/biostar/a68n_5200/buildOpts.c
M src/mainboard/biostar/am1ml/buildOpts.c
M src/mainboard/gizmosphere/gizmo2/buildOpts.c
M src/mainboard/hp/abm/buildOpts.c
M src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
M src/mainboard/lenovo/g505s/buildOpts.c
M src/mainboard/msi/ms7721/buildOpts.c
14 files changed, 0 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/41588/1

diff --git a/src/mainboard/amd/olivehill/buildOpts.c b/src/mainboard/amd/olivehill/buildOpts.c
index 78a5596..fd61756 100644
--- a/src/mainboard/amd/olivehill/buildOpts.c
+++ b/src/mainboard/amd/olivehill/buildOpts.c
@@ -306,7 +306,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   olivehill_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c
index bf61067..c46657d 100644
--- a/src/mainboard/amd/parmer/buildOpts.c
+++ b/src/mainboard/amd/parmer/buildOpts.c
@@ -307,7 +307,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   parmer_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c
index de1f89f..915f792 100644
--- a/src/mainboard/amd/thatcher/buildOpts.c
+++ b/src/mainboard/amd/thatcher/buildOpts.c
@@ -307,7 +307,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33
 #define FCH_NO_XHCI_SUPPORT			TRUE
 GPIO_CONTROL   thatcher_gpio[] = {
    {183, Function1, PullUpB},
diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c
index 4ed3a89..9fc4a43 100644
--- a/src/mainboard/asrock/imb-a180/buildOpts.c
+++ b/src/mainboard/asrock/imb-a180/buildOpts.c
@@ -306,7 +306,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   imba180_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c
index bbe1642..49fcb22 100644
--- a/src/mainboard/asus/am1i-a/buildOpts.c
+++ b/src/mainboard/asus/am1i-a/buildOpts.c
@@ -318,7 +318,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   imba180_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c
index 29a717d..e2fe66c 100644
--- a/src/mainboard/asus/f2a85-m/buildOpts.c
+++ b/src/mainboard/asus/f2a85-m/buildOpts.c
@@ -309,7 +309,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33
 //#define FCH_NO_XHCI_SUPPORT			FALSE
 GPIO_CONTROL   f2a85_m_gpio[] = {
 //	{183, Function1, PullUpB},
diff --git a/src/mainboard/bap/ode_e20XX/buildOpts.c b/src/mainboard/bap/ode_e20XX/buildOpts.c
index f2956a1..ec4e17e 100644
--- a/src/mainboard/bap/ode_e20XX/buildOpts.c
+++ b/src/mainboard/bap/ode_e20XX/buildOpts.c
@@ -305,7 +305,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   gizmo2_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/biostar/a68n_5200/buildOpts.c b/src/mainboard/biostar/a68n_5200/buildOpts.c
index 78a5596..fd61756 100644
--- a/src/mainboard/biostar/a68n_5200/buildOpts.c
+++ b/src/mainboard/biostar/a68n_5200/buildOpts.c
@@ -306,7 +306,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   olivehill_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/biostar/am1ml/buildOpts.c b/src/mainboard/biostar/am1ml/buildOpts.c
index b25be51..8cc90ddb 100644
--- a/src/mainboard/biostar/am1ml/buildOpts.c
+++ b/src/mainboard/biostar/am1ml/buildOpts.c
@@ -306,7 +306,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   imba180_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/gizmosphere/gizmo2/buildOpts.c b/src/mainboard/gizmosphere/gizmo2/buildOpts.c
index f2956a1..ec4e17e 100644
--- a/src/mainboard/gizmosphere/gizmo2/buildOpts.c
+++ b/src/mainboard/gizmosphere/gizmo2/buildOpts.c
@@ -305,7 +305,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   gizmo2_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/hp/abm/buildOpts.c b/src/mainboard/hp/abm/buildOpts.c
index 337d35c..05ed014 100644
--- a/src/mainboard/hp/abm/buildOpts.c
+++ b/src/mainboard/hp/abm/buildOpts.c
@@ -310,7 +310,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   hp_abm_gpio[] = {
    { 45, Function2, GpioOutEnB | Sticky },                   // Signal input  APU_SD_LED
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
index 989df12..c46ba74 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
+++ b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
@@ -309,7 +309,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

/*
  * The GPIO control is not well documented in AGESA, but is in the BKDG
diff --git a/src/mainboard/lenovo/g505s/buildOpts.c b/src/mainboard/lenovo/g505s/buildOpts.c
index 70ac825..6351aee 100644
--- a/src/mainboard/lenovo/g505s/buildOpts.c
+++ b/src/mainboard/lenovo/g505s/buildOpts.c
@@ -309,7 +309,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

/*
  * The GPIO control is not well documented in AGESA, but is in the BKDG
diff --git a/src/mainboard/msi/ms7721/buildOpts.c b/src/mainboard/msi/ms7721/buildOpts.c
index ce55623..d7e8c85 100644
--- a/src/mainboard/msi/ms7721/buildOpts.c
+++ b/src/mainboard/msi/ms7721/buildOpts.c
@@ -309,7 +309,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33
 //#define FCH_NO_XHCI_SUPPORT			FALSE
 GPIO_CONTROL   ms7721_m_gpio[] = {
 //	{183, Function1, PullUpB},

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41588 )

Change subject: mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Paul Menzel, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41588

to look at the new patch set (#2).

Change subject: mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL
......................................................................

mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL

This does not exist anywhere in the entire coreboot tree. Drop it.

TEST=Use abuild --timeless to check that all AGESA f14/f15tn/f16kb
mainboards result in identical coreboot binaries.

Change-Id: I80320a20f4b44896e72d701a1d98786cb3a93dcc
Signed-off-by: Angel Pons 
---
M src/mainboard/amd/olivehill/buildOpts.c
M src/mainboard/amd/parmer/buildOpts.c
M src/mainboard/amd/thatcher/buildOpts.c
M src/mainboard/asrock/imb-a180/buildOpts.c
M src/mainboard/asus/am1i-a/buildOpts.c
M src/mainboard/asus/f2a85-m/buildOpts.c
M src/mainboard/bap/ode_e20XX/buildOpts.c
M src/mainboard/biostar/a68n_5200/buildOpts.c
M src/mainboard/biostar/am1ml/buildOpts.c
M src/mainboard/gizmosphere/gizmo2/buildOpts.c
M src/mainboard/hp/abm/buildOpts.c
M src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
M src/mainboard/lenovo/g505s/buildOpts.c
M src/mainboard/msi/ms7721/buildOpts.c
14 files changed, 0 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/41588/2

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41588 )

Change subject: mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL
......................................................................

Patch Set 2: Code-Review+2

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41588 )

Change subject: mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL
......................................................................

Patch Set 2:

I will do this in A88XM-E change as well.

[Krystian Hebel (Code Review)]

Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41588 )

Change subject: mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL
......................................................................

Patch Set 2: Code-Review+1

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41588 )

Change subject: mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL
......................................................................

mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL

This does not exist anywhere in the entire coreboot tree. Drop it.

TEST=Use abuild --timeless to check that all AGESA f14/f15tn/f16kb
mainboards result in identical coreboot binaries.

Change-Id: I80320a20f4b44896e72d701a1d98786cb3a93dcc
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41588
Tested-by: build bot (Jenkins) 
Reviewed-by: Mike Banon 
Reviewed-by: Krystian Hebel 
---
M src/mainboard/amd/olivehill/buildOpts.c
M src/mainboard/amd/parmer/buildOpts.c
M src/mainboard/amd/thatcher/buildOpts.c
M src/mainboard/asrock/imb-a180/buildOpts.c
M src/mainboard/asus/am1i-a/buildOpts.c
M src/mainboard/asus/f2a85-m/buildOpts.c
M src/mainboard/bap/ode_e20XX/buildOpts.c
M src/mainboard/biostar/a68n_5200/buildOpts.c
M src/mainboard/biostar/am1ml/buildOpts.c
M src/mainboard/gizmosphere/gizmo2/buildOpts.c
M src/mainboard/hp/abm/buildOpts.c
M src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
M src/mainboard/lenovo/g505s/buildOpts.c
M src/mainboard/msi/ms7721/buildOpts.c
14 files changed, 0 insertions(+), 14 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Mike Banon: Looks good to me, approved
  Krystian Hebel: Looks good to me, but someone else must approve

diff --git a/src/mainboard/amd/olivehill/buildOpts.c b/src/mainboard/amd/olivehill/buildOpts.c
index 78a5596..fd61756 100644
--- a/src/mainboard/amd/olivehill/buildOpts.c
+++ b/src/mainboard/amd/olivehill/buildOpts.c
@@ -306,7 +306,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   olivehill_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c
index bf61067..c46657d 100644
--- a/src/mainboard/amd/parmer/buildOpts.c
+++ b/src/mainboard/amd/parmer/buildOpts.c
@@ -307,7 +307,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   parmer_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c
index de1f89f..915f792 100644
--- a/src/mainboard/amd/thatcher/buildOpts.c
+++ b/src/mainboard/amd/thatcher/buildOpts.c
@@ -307,7 +307,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33
 #define FCH_NO_XHCI_SUPPORT			TRUE
 GPIO_CONTROL   thatcher_gpio[] = {
    {183, Function1, PullUpB},
diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c
index 4ed3a89..9fc4a43 100644
--- a/src/mainboard/asrock/imb-a180/buildOpts.c
+++ b/src/mainboard/asrock/imb-a180/buildOpts.c
@@ -306,7 +306,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   imba180_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c
index bbe1642..49fcb22 100644
--- a/src/mainboard/asus/am1i-a/buildOpts.c
+++ b/src/mainboard/asus/am1i-a/buildOpts.c
@@ -318,7 +318,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   imba180_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c
index 29a717d..e2fe66c 100644
--- a/src/mainboard/asus/f2a85-m/buildOpts.c
+++ b/src/mainboard/asus/f2a85-m/buildOpts.c
@@ -309,7 +309,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33
 //#define FCH_NO_XHCI_SUPPORT			FALSE
 GPIO_CONTROL   f2a85_m_gpio[] = {
 //	{183, Function1, PullUpB},
diff --git a/src/mainboard/bap/ode_e20XX/buildOpts.c b/src/mainboard/bap/ode_e20XX/buildOpts.c
index f2956a1..ec4e17e 100644
--- a/src/mainboard/bap/ode_e20XX/buildOpts.c
+++ b/src/mainboard/bap/ode_e20XX/buildOpts.c
@@ -305,7 +305,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   gizmo2_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/biostar/a68n_5200/buildOpts.c b/src/mainboard/biostar/a68n_5200/buildOpts.c
index 78a5596..fd61756 100644
--- a/src/mainboard/biostar/a68n_5200/buildOpts.c
+++ b/src/mainboard/biostar/a68n_5200/buildOpts.c
@@ -306,7 +306,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   olivehill_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/biostar/am1ml/buildOpts.c b/src/mainboard/biostar/am1ml/buildOpts.c
index b25be51..8cc90ddb 100644
--- a/src/mainboard/biostar/am1ml/buildOpts.c
+++ b/src/mainboard/biostar/am1ml/buildOpts.c
@@ -306,7 +306,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   imba180_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/gizmosphere/gizmo2/buildOpts.c b/src/mainboard/gizmosphere/gizmo2/buildOpts.c
index f2956a1..ec4e17e 100644
--- a/src/mainboard/gizmosphere/gizmo2/buildOpts.c
+++ b/src/mainboard/gizmosphere/gizmo2/buildOpts.c
@@ -305,7 +305,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   gizmo2_gpio[] = {
    {183, Function1, GpioIn | GpioOutEnB | PullUpB},
diff --git a/src/mainboard/hp/abm/buildOpts.c b/src/mainboard/hp/abm/buildOpts.c
index 337d35c..05ed014 100644
--- a/src/mainboard/hp/abm/buildOpts.c
+++ b/src/mainboard/hp/abm/buildOpts.c
@@ -310,7 +310,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

GPIO_CONTROL   hp_abm_gpio[] = {
    { 45, Function2, GpioOutEnB | Sticky },                   // Signal input  APU_SD_LED
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
index 989df12..c46ba74 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
+++ b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
@@ -309,7 +309,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

/*
  * The GPIO control is not well documented in AGESA, but is in the BKDG
diff --git a/src/mainboard/lenovo/g505s/buildOpts.c b/src/mainboard/lenovo/g505s/buildOpts.c
index 70ac825..6351aee 100644
--- a/src/mainboard/lenovo/g505s/buildOpts.c
+++ b/src/mainboard/lenovo/g505s/buildOpts.c
@@ -309,7 +309,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33

/*
  * The GPIO control is not well documented in AGESA, but is in the BKDG
diff --git a/src/mainboard/msi/ms7721/buildOpts.c b/src/mainboard/msi/ms7721/buildOpts.c
index ce55623..d7e8c85 100644
--- a/src/mainboard/msi/ms7721/buildOpts.c
+++ b/src/mainboard/msi/ms7721/buildOpts.c
@@ -309,7 +309,6 @@
 #define DFLT_FCH_GPP_PORT1_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT2_HOTPLUG          FALSE
 #define DFLT_FCH_GPP_PORT3_HOTPLUG          FALSE
-//#define BLDCFG_IR_PIN_CONTROL	0x33
 //#define FCH_NO_XHCI_SUPPORT			FALSE
 GPIO_CONTROL   ms7721_m_gpio[] = {
 //	{183, Function1, PullUpB},

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41588 )

Change subject: mb/*/*/buildOpts.c: Drop BLDCFG_IR_PIN_CONTROL
......................................................................

Patch Set 6:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3967
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3966
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3965
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3964

Please note: This test is under development and might not be accurate at all!