Change in coreboot[master]: arch/x86/ioapic: clear full upper byte when writing ID register - coreboot-gerrit

11 Feb 2021


      Attention is currently required from: Raul Rangel, Nico Huber, Martin Roth, Angel Pons, Arthur Heymans, Kyösti Mälkki, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50574 )
Change subject: arch/x86/ioapic: clear full upper byte when writing ID register
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50574/comment/191a0a67_a2168eca 
PS1, Line 15: bit's
nit, no apostrophe
Patchset:
PS1: 
I don't see a problem with the extra nibble though.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50574
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id730ed0abbe69d4679ec07910230cae1881c6c9a
Gerrit-Change-Number: 50574
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 12 Feb 2021 00:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment