Change in ...coreboot[master]: soc/intel/common/block/cpu: Use core apic id to get cpu_index()
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26346 )
Change subject: soc/intel/common/block/cpu: Use core apic id to get cpu_index() ......................................................................
Patch Set 10:
(1 comment)
Why is it needed? As far as I understand FSP 2.1, that introduced MP_SERVICES_PPI, also introduced shared stack when selecting FSP_USES_CB_STACK. Simply select FSP_USES_CB_STACK when using MP_SERVICES_PPI should fix the issue.
The reason is that, on FSP2.0 platform also we might need to enable MP PPI feature but same stack sharing concept might not applied on FSP 2.0 enabled platform, hence we are looking for some solution to bypass stack dependencies.
https://review.coreboot.org/#/c/26346/10/src/soc/intel/common/block/cpu/cpul... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/#/c/26346/10/src/soc/intel/common/block/cpu/cpul... PS10, Line 327: unsigned long cpu_index(void)
will this function work for all x86 that exist? I believe it will. […]
true, i believe this function qualify good to enable on all x86 platform
-
Subrata Banik (Code Review)