Hello Frans Hendriks,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37615
to review the following change.
Change subject: mb/{facebook/portwell}; Remove empty onboard.h ......................................................................
mb/{facebook/portwell}; Remove empty onboard.h
Defines in onboard.h are moved to other files. Remove this empty and unused file.
BUG=N/A TEST=build
Change-Id: Ide10b352eadcffad2d4221865124f64466af5a1c Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- D src/mainboard/facebook/fbg1701/onboard.h D src/mainboard/portwell/m107/onboard.h 2 files changed, 0 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37615/1
diff --git a/src/mainboard/facebook/fbg1701/onboard.h b/src/mainboard/facebook/fbg1701/onboard.h deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/facebook/fbg1701/onboard.h +++ /dev/null diff --git a/src/mainboard/portwell/m107/onboard.h b/src/mainboard/portwell/m107/onboard.h deleted file mode 100644 index 3a5dee2..0000000 --- a/src/mainboard/portwell/m107/onboard.h +++ /dev/null @@ -1,24 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Google Inc. - * Copyright (C) 2015 Intel Corp. - * Copyright (C) 2018 Eltan B.V. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef ONBOARD_H -#define ONBOARD_H - -/* SD CARD gpio */ -#define SDCARD_CD 81 /* Not used */ - -#endif
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37615 )
Change subject: mb/{facebook/portwell}; Remove empty onboard.h ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37615/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37615/1//COMMIT_MSG@7 PS1, Line 7: mb/{facebook/portwell}; Remove empty onboard.h replace ; by :
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37615
to look at the new patch set (#2).
Change subject: mb/{facebook/portwell}: Remove empty onboard.h ......................................................................
mb/{facebook/portwell}: Remove empty onboard.h
Defines in onboard.h are moved to other files. Remove this empty and unused file.
BUG=N/A TEST=build
Change-Id: Ide10b352eadcffad2d4221865124f64466af5a1c Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- D src/mainboard/facebook/fbg1701/onboard.h D src/mainboard/portwell/m107/onboard.h 2 files changed, 0 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37615/2
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37615 )
Change subject: mb/{facebook/portwell}: Remove empty onboard.h ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37615/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37615/1//COMMIT_MSG@7 PS1, Line 7: mb/{facebook/portwell}; Remove empty onboard.h
replace ; by :
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37615 )
Change subject: mb/{facebook/portwell}: Remove empty onboard.h ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37615 )
Change subject: mb/{facebook/portwell}: Remove empty onboard.h ......................................................................
mb/{facebook/portwell}: Remove empty onboard.h
Defines in onboard.h are moved to other files. Remove this empty and unused file.
BUG=N/A TEST=build
Change-Id: Ide10b352eadcffad2d4221865124f64466af5a1c Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37615 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- D src/mainboard/facebook/fbg1701/onboard.h D src/mainboard/portwell/m107/onboard.h 2 files changed, 0 insertions(+), 24 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/onboard.h b/src/mainboard/facebook/fbg1701/onboard.h deleted file mode 100644 index e69de29..0000000 --- a/src/mainboard/facebook/fbg1701/onboard.h +++ /dev/null diff --git a/src/mainboard/portwell/m107/onboard.h b/src/mainboard/portwell/m107/onboard.h deleted file mode 100644 index 3a5dee2..0000000 --- a/src/mainboard/portwell/m107/onboard.h +++ /dev/null @@ -1,24 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Google Inc. - * Copyright (C) 2015 Intel Corp. - * Copyright (C) 2018 Eltan B.V. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef ONBOARD_H -#define ONBOARD_H - -/* SD CARD gpio */ -#define SDCARD_CD 81 /* Not used */ - -#endif
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Wim Vervoorn (Code Review)