[XS] Change in coreboot[main]: mb/google/nissa: Fix potential null pointer dereference - coreboot-gerrit

24 May 2024


      Attention is currently required from: Kapil Porwal, Nick Vaccaro, Subrata Banik.
Eric Lai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/82628?usp=email )
Change subject: mb/google/nissa: Fix potential null pointer dereference
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/baseboard/nissa/ramstage.c:
https://review.coreboot.org/c/coreboot/+/82628/comment/d105eccf_7bb0f674?usp... :
PS1, Line 19: 	if (override_pads != NULL)
...
...
As long as the override_num is 0 is fine. […]
sure good to have :p
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/82628?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I733210a08091b37eda6e6b0d6924aafd5e7e6280
Gerrit-Change-Number: 82628
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 24 May 2024 05:11:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai ericllai@google.com
Comment-In-Reply-To: Subrata Banik subratabanik@google.com