Change in coreboot[master]: util/liveiso: Merge build scripts - coreboot-gerrit

26 Dec 2021


      Attention is currently required from:  Felix Singer.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 )
Change subject: util/liveiso: Merge build scripts
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File util/liveiso/build.sh:
https://review.coreboot.org/c/coreboot/+/60372/comment/aa72387c_89186793 
PS1, Line 6: echo "No config given. Exiting."
maybe also print usage like this? "Usage: build.sh <graphical.nix|console.nix|...>"
https://review.coreboot.org/c/coreboot/+/60372/comment/faddfbc1_12c28ca5 
PS1, Line 12: nixos-config=$config
could be `nixos-config=${config}.nix` - not requirement, just some random idea :)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60372
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83
Gerrit-Change-Number: 60372
Gerrit-PatchSet: 1
Gerrit-Owner:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention:  Felix Singer felixsinger@posteo.net
Gerrit-Comment-Date: Sun, 26 Dec 2021 10:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment